classification
Title: leftover thread crumb in threading.ident docstring
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, skip.montanaro, zach.ware
Priority: normal Keywords: easy, patch

Created on 2018-05-17 13:53 by skip.montanaro, last changed 2018-05-18 19:48 by zach.ware. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6963 merged skip.montanaro, 2018-05-18 02:32
PR 6974 merged miss-islington, 2018-05-18 18:39
PR 6975 merged miss-islington, 2018-05-18 18:40
Messages (6)
msg316931 - (view) Author: Skip Montanaro (skip.montanaro) * (Python triager) Date: 2018-05-17 13:53
There is a leftover reference to "thread.get_ident" in the docstring for threading.ident. I believe it needs a leading underscore.

Hopefully a PR isn't required for this. I'm not equipped to generate one at the moment, and this seems like a pretty trivial/obvious fix.
msg316934 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2018-05-17 14:13
Rather than a leading underscore, I think `thread.` should just be removed.  `get_ident` is now exposed by the threading module itself.

For a change this small, https://github.com/python/cpython/edit/master/Lib/threading.py can be used to create it, but every change requires a PR :)
msg317047 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2018-05-18 18:38
New changeset 5634331a76dfe9fbe4b76475e11307a0922d6a15 by Zachary Ware (Skip Montanaro) in branch 'master':
bpo-33556: Remove reference to thread module from docstring (GH-6963)
https://github.com/python/cpython/commit/5634331a76dfe9fbe4b76475e11307a0922d6a15
msg317051 - (view) Author: miss-islington (miss-islington) Date: 2018-05-18 19:32
New changeset c6a5cc8f244ee71ce932003366411aacadda8dd0 by Miss Islington (bot) in branch '3.6':
bpo-33556: Remove reference to thread module from docstring (GH-6963)
https://github.com/python/cpython/commit/c6a5cc8f244ee71ce932003366411aacadda8dd0
msg317054 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2018-05-18 19:46
New changeset abde17e663edd6437cc7eb0405fe418449a25d72 by Zachary Ware (Miss Islington (bot)) in branch '3.7':
bpo-33556: Remove reference to thread module from docstring (GH-6963)
https://github.com/python/cpython/commit/abde17e663edd6437cc7eb0405fe418449a25d72
msg317055 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2018-05-18 19:48
Done, thanks Skip :)

Can we convince you to reclaim your commit bits so you can click the buttons yourself next time? ;)
History
Date User Action Args
2018-05-18 19:48:49zach.waresetstatus: open -> closed
resolution: fixed
messages: + msg317055

stage: patch review -> resolved
2018-05-18 19:46:53zach.waresetmessages: + msg317054
2018-05-18 19:32:22miss-islingtonsetnosy: + miss-islington
messages: + msg317051
2018-05-18 18:40:47miss-islingtonsetpull_requests: + pull_request6630
2018-05-18 18:39:48miss-islingtonsetpull_requests: + pull_request6629
2018-05-18 18:38:42zach.waresetmessages: + msg317047
2018-05-18 02:32:03skip.montanarosetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request6622
2018-05-17 14:13:20zach.waresetnosy: + zach.ware
messages: + msg316934
2018-05-17 13:53:10skip.montanarocreate