classification
Title: test_cprofile should fail instead of displaying a message
Type: Stage: resolved
Components: Tests Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, jdemeyer, miss-islington
Priority: normal Keywords: patch

Created on 2018-05-08 14:29 by jdemeyer, last changed 2018-05-09 04:59 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6727 merged jdemeyer, 2018-05-08 14:41
PR 6736 merged miss-islington, 2018-05-09 04:17
PR 6737 merged miss-islington, 2018-05-09 04:18
Messages (4)
msg316287 - (view) Author: Jeroen Demeyer (jdemeyer) * (Python triager) Date: 2018-05-08 14:29
When this test from Lib/test/test_profile.py fail, it just prints a message and doesn't fail the testsuite:

    def test_cprofile(self):
        results = self.do_profiling()
        expected = self.get_expected_output()
        self.assertEqual(results[0], 1000)
        for i, method in enumerate(self.methodnames):
            if results[i+1] != expected[method]:
                print("Stats.%s output for %s doesn't fit expectation!" %
                      (method, self.profilerclass.__name__))
                print('\n'.join(unified_diff(
                                  results[i+1].split('\n'),
                                  expected[method].split('\n'))))
msg316306 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2018-05-09 04:16
New changeset ac9240b9be31d073d1b2e50ce53481ff0fc9ed23 by Benjamin Peterson (jdemeyer) in branch 'master':
closes bpo-33445: fail properly in test_cprofile() (GH-6727)
https://github.com/python/cpython/commit/ac9240b9be31d073d1b2e50ce53481ff0fc9ed23
msg316307 - (view) Author: miss-islington (miss-islington) Date: 2018-05-09 04:38
New changeset 263523ae217e1af580628b4fe0609194823a51aa by Miss Islington (bot) in branch '3.7':
closes bpo-33445: fail properly in test_cprofile() (GH-6727)
https://github.com/python/cpython/commit/263523ae217e1af580628b4fe0609194823a51aa
msg316308 - (view) Author: miss-islington (miss-islington) Date: 2018-05-09 04:59
New changeset c925108b991b9c5f0402feb0e7f725ee3ac7da11 by Miss Islington (bot) in branch '3.6':
closes bpo-33445: fail properly in test_cprofile() (GH-6727)
https://github.com/python/cpython/commit/c925108b991b9c5f0402feb0e7f725ee3ac7da11
History
Date User Action Args
2018-05-09 04:59:57miss-islingtonsetmessages: + msg316308
2018-05-09 04:38:03miss-islingtonsetnosy: + miss-islington
messages: + msg316307
2018-05-09 04:18:44miss-islingtonsetpull_requests: + pull_request6426
2018-05-09 04:17:45miss-islingtonsetpull_requests: + pull_request6425
2018-05-09 04:16:38benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg316306

resolution: fixed
stage: patch review -> resolved
2018-05-08 14:41:15jdemeyersetkeywords: + patch
stage: patch review
pull_requests: + pull_request6420
2018-05-08 14:29:58jdemeyercreate