➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008-07-11 22:41 by taleinat, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| IDLE_EditorWindow_minor.patch | taleinat, 2008-07-11 22:41 | initial patch | ||
| Messages (7) | |||
|---|---|---|---|
| msg69571 - (view) | Author: Tal Einat (taleinat) *  |
Date: 2008-07-11 22:41 | |
Just minor code cleanup. Only one instance of zip(count(), ...) in EditorWindow.py, where I also changed 'file' to 'file_name' to avoid overriding the built-in 'file' class. |
|||
| msg69999 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2008-07-19 02:26 | |
This looks as straightforward as patches get. I verified that itertools.count is not used elsewhere in the file, so it is ok to zap the import. Suggest apply. |
|||
| msg86615 - (view) | Author: Daniel Diniz (ajaksu2) *  |
Date: 2009-04-26 22:12 | |
+1 on committing this. |
|||
| msg86630 - (view) | Author: Raymond Hettinger (rhettinger) * |
Date: 2009-04-26 23:40 | |
I would leave the variable name unchanged. Also, better to use rstrip than file[0:-1]. |
|||
| msg86631 - (view) | Author: Guilherme Polo (gpolo) * |
Date: 2009-04-26 23:45 | |
I would prefer to rename it, why waste the "chance" to rename something badly named ? I agree on the rstrip use. |
|||
| msg91549 - (view) | Author: Guilherme Polo (gpolo) * |
Date: 2009-08-14 13:54 | |
Committed on r74446, will merge into py3k. |
|||
| msg91555 - (view) | Author: Guilherme Polo (gpolo) * |
Date: 2009-08-14 15:08 | |
> Committed on r74446, will merge into py3k. py3k: r74450 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:36 | admin | set | github: 47594 |
| 2009-08-14 15:08:21 | gpolo | set | messages: + msg91555 |
| 2009-08-14 13:54:22 | gpolo | set | status: open -> closed resolution: accepted messages: + msg91549 |
| 2009-04-26 23:45:38 | gpolo | set | messages: + msg86631 |
| 2009-04-26 23:40:19 | rhettinger | set | nosy:
+ rhettinger messages: + msg86630 |
| 2009-04-26 22:12:06 | ajaksu2 | set | priority: normal type: enhancement versions: + Python 3.1, Python 2.7 nosy: + ajaksu2, gpolo messages: + msg86615 stage: patch review |
| 2008-07-21 23:03:56 | amaury.forgeotdarc | set | assignee: kbk |
| 2008-07-19 02:27:05 | terry.reedy | set | nosy:
+ terry.reedy messages: + msg69999 |
| 2008-07-19 02:19:24 | terry.reedy | set | components: + IDLE |
| 2008-07-11 22:41:52 | taleinat | create | |