classification
Title: [EASY C] test_posix.test_posix_spawn_file_actions() leaks memory
Type: Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: duplicate
Dependencies: Superseder: expose posix_spawn(p)
View: 20104
Assigned To: Nosy List: pablogsal, vstinner
Priority: normal Keywords:

Created on 2018-04-25 14:39 by vstinner, last changed 2018-05-29 21:32 by vstinner. This issue is now closed.

Messages (3)
msg315740 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-04-25 14:39
vstinner@apu$ ./python -m test test_posix -R 3:3 -m test.test_posix.PosixTester.test_posix_spawn_file_actions
Run tests sequentially
0:00:00 load avg: 0.58 [1/1] test_posix
beginning 6 repetitions
123456
......
test_posix leaked [7, 7, 7] references, sum=21
test_posix leaked [1, 2, 1] memory blocks, sum=4
test_posix failed

1 test failed:
    test_posix

Total duration: 315 ms
Tests result: FAILURE


I bet that the leak was introduced by:

commit 6c6ddf97c402709713d668d0ed53836a7749ba99
Author: Pablo Galindo <Pablogsal@gmail.com>
Date:   Mon Jan 29 01:56:10 2018 +0000

    bpo-20104: Expose `posix_spawn` in the os module (GH-5109)
    
    Add os.posix_spawn to wrap the low level POSIX API of the same name.
    
    Contributed by Pablo Galindo.

--

IMHO this issue is easy to fix, so I suggest to leave it to new contributors, or the author of the change.
msg315743 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-04-25 14:56
I think PR6332 is already addressing this https://github.com/python/cpython/pull/6332 , right?
msg315744 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-04-25 14:59
I confirm that PR 6332 fixes the leak.
History
Date User Action Args
2018-05-29 21:32:22vstinnersetstatus: open -> closed
resolution: duplicate
stage: resolved
2018-04-25 15:03:53pablogsalsetsuperseder: expose posix_spawn(p)
2018-04-25 14:59:03vstinnersetmessages: + msg315744
2018-04-25 14:56:22pablogsalsetmessages: + msg315743
2018-04-25 14:39:30vstinnersetnosy: + pablogsal
2018-04-25 14:39:14vstinnercreate