Created on 2018-03-28 00:47 by onlined, last changed 2018-08-03 18:56 by berker.peksag. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 6275 | closed | onlined, 2018-03-28 01:08 | |
| Messages (2) | |||
|---|---|---|---|
| msg314562 - (view) | Author: Ekin Dursun (onlined) * | Date: 2018-03-28 00:47 | |
At line 245, default value for drv is provided with KeyError handling, but it is better to use dict's get method. |
|||
| msg323063 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2018-08-03 18:56 | |
Thanks for the PR, but we usually avoid unnecessary churn in Python codebase. Both versions look fine, and deciding which one to use is just a matter of personal taste. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2018-08-03 18:56:25 | berker.peksag | set | status: open -> closed components: - Windows nosy: + berker.peksag, - paul.moore, tim.golden, zach.ware, steve.dower messages: + msg323063 resolution: rejected stage: patch review -> resolved |
| 2018-03-28 01:08:02 | onlined | set | keywords:
+ patch stage: patch review pull_requests: + pull_request6002 |
| 2018-03-28 00:47:21 | onlined | create | |