Created on 2018-03-27 08:05 by Windson Yang, last changed 2018-03-30 19:04 by eric.araujo. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 6269 | closed | python-dev, 2018-03-27 08:08 | |
| Messages (2) | |||
|---|---|---|---|
| msg314504 - (view) | Author: Windson Yang (Windson Yang) * | Date: 2018-03-27 08:05 | |
https://github.com/python/cpython/blob/master/Lib/timeit.py#L202 use a list comprehension instead |
|||
| msg314529 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2018-03-27 15:10 | |
We usually do not do such kind of changes due to the risk of introducing new bugs (as your PR demonstrated). Only when other changes are applied to the module, the surrounded code can be cleaned up. Or the maintainer of the module can do this if he decided that it is a time for modernization. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2018-03-30 19:04:38 | eric.araujo | set | status: open -> closed type: behavior -> resolution: not a bug components: + Library (Lib), - Distutils stage: patch review -> resolved |
| 2018-03-27 15:10:39 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg314529 |
| 2018-03-27 15:02:40 | pablogsal | set | title: clean code -> Use list comprehension in timeit module instead of loop with append |
| 2018-03-27 08:08:10 | python-dev | set | keywords:
+ patch stage: patch review pull_requests: + pull_request5994 |
| 2018-03-27 08:05:41 | Windson Yang | create | |