classification
Title: importlib.resources breaks on subdirectories
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: barry Nosy List: barry, brett.cannon
Priority: normal Keywords: patch

Created on 2018-03-27 04:47 by barry, last changed 2018-03-27 17:25 by barry. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 6268 merged barry, 2018-03-27 05:30
PR 6270 merged miss-islington, 2018-03-27 17:00
Messages (4)
msg314500 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2018-03-27 04:47
Found a bug when trying to read a resource from a subpackage in a zip file.  I was actually surprised we didn't have a test for this AFAICT, and when I added one, it did fail.

I have a PR coming soon.
msg314501 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2018-03-27 05:29
is_resource() from zip submodules is also affected
msg314540 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2018-03-27 16:59
New changeset 30e507dff465a31901d87df791a2bac40dc88530 by Barry Warsaw in branch 'master':
bpo-33151: Handle submodule resources (GH-6268)
https://github.com/python/cpython/commit/30e507dff465a31901d87df791a2bac40dc88530
msg314542 - (view) Author: Barry A. Warsaw (barry) * (Python committer) Date: 2018-03-27 17:25
New changeset fd1b8f87b3e63495cadd37c8f1b90191b46ee52a by Barry Warsaw (Miss Islington (bot)) in branch '3.7':
bpo-33151: Handle submodule resources (GH-6268) (GH-6270)
https://github.com/python/cpython/commit/fd1b8f87b3e63495cadd37c8f1b90191b46ee52a
History
Date User Action Args
2018-03-27 17:25:51barrysetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-03-27 17:25:34barrysetmessages: + msg314542
2018-03-27 17:00:05miss-islingtonsetpull_requests: + pull_request5998
2018-03-27 16:59:43barrysetmessages: + msg314540
2018-03-27 05:30:49barrysetkeywords: + patch
stage: patch review
pull_requests: + pull_request5993
2018-03-27 05:29:10barrysetmessages: + msg314501
2018-03-27 04:47:44barrycreate