Issue 33024: asyncio.WriteTransport.set_write_buffer_limits orders its args unintuitively and inconsistently with its companion function's return value

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/77205

classification

Title:	asyncio.WriteTransport.set_write_buffer_limits orders its args unintuitively and inconsistently with its companion function's return value
Type:	behavior	Stage:
Components:	asyncio	Versions:	Python 3.7, Python 3.6

process

Status:	open	Resolution:
Dependencies:		Superseder:
Assigned To:		Nosy List:	asvetlov, vitaly.krug, yselivanov
Priority:	normal	Keywords:

Created on 2018-03-08 06:24 by vitaly.krug, last changed 2022-04-11 14:58 by admin.

Messages (2)
msg313423 - (view)	Author: Vitaly Kruglikov (vitaly.krug)	Date: 2018-03-08 06:24
`asyncio.WriteTransport.set_write_buffer_limits()` uses an unintuitive order of the args (high, low). I would expect `low` to be the first arg, especially since `asyncio.WriteTransport.get_write_buffer_limits()` returns them in the opposite order. This ordering and inconsistency with the companion function's return value is error-prone. See https://docs.python.org/3/library/asyncio-protocol.html#asyncio.WriteTransport.set_write_buffer_limits
msg313435 - (view)	Author: Andrew Svetlov (asvetlov) *	Date: 2018-03-08 11:51
We cannot change the method signature without breaking backward compatibility. I doubt if we should do something with the issue.