classification
Title: distutils.command.install checks truthiness of .ext_modules instead of calling .has_ext_modules()
Type: behavior Stage: resolved
Components: Distutils Versions: Python 3.8, Python 3.7, Python 3.6, Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: dstufft, eric.araujo, korijn, steve.dower
Priority: normal Keywords: patch

Created on 2018-02-26 15:24 by korijn, last changed 2021-02-03 18:19 by steve.dower. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 5909 closed korijn, 2018-02-26 15:27
Messages (2)
msg312932 - (view) Author: Korijn Van Golen (korijn) Date: 2018-02-26 15:24
distutils' Distribution class has a method has_ext_modules() that is used to determine if any extension modules are included in a distribution. There remains a call site in distutils.command.install where self.distribution.ext_modules is directly tested for truthiness, rather than calling has_ext_modules. This causes inconsistent behavior, e.g. when overriding has_ext_modules in a Distribution subclass.
msg386332 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2021-02-03 18:19
Distutils is now deprecated (see PEP 632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils.

If this issue does not relate to distutils, please remove the component and reopen it. If you believe it still requires a fix, most likely the issue should be re-reported at https://github.com/pypa/setuptools
History
Date User Action Args
2021-02-03 18:19:25steve.dowersetstatus: open -> closed

nosy: + steve.dower
messages: + msg386332

resolution: out of date
stage: patch review -> resolved
2018-02-26 15:27:19korijnsetkeywords: + patch
stage: patch review
pull_requests: + pull_request5679
2018-02-26 15:24:42korijncreate