classification
Title: Typo in documentation of unittest: whilst instead of while
Type: Stage: resolved
Components: Documentation Versions: Python 3.8, Python 3.7, Python 3.6, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Mariatta, docs@python, eric.smith, mark.dickinson, miss-islington, Тимофей Хирьянов
Priority: normal Keywords: patch

Created on 2018-02-23 15:30 by Тимофей Хирьянов, last changed 2018-02-23 18:22 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 5833 merged Mariatta, 2018-02-23 17:21
PR 5836 merged miss-islington, 2018-02-23 17:52
PR 5837 merged miss-islington, 2018-02-23 17:53
PR 5838 merged miss-islington, 2018-02-23 17:54
Messages (10)
msg312637 - (view) Author: Тимофей Хирьянов (Тимофей Хирьянов) Date: 2018-02-23 15:30
Typo is on the https://docs.python.org/3/library/unittest.html page.

At bottom of the page you can see text: "unittest.removeHandler(function=None)
When called without arguments this function removes the control-c handler if it has been installed. This function can also be used as a test decorator to temporarily remove the handler whilst the test is being executed:"

Typo is: ST instead of E in the word "whilst".
msg312638 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2018-02-23 16:20
Not a typo: it's a valid English word.

http://dictionary.cambridge.org/grammar/british-grammar/linking-words-and-expressions/while-and-whilst
msg312644 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2018-02-23 16:49
`while` and `whilst` are both valid english words, however I can understand if readers who don't primarily speak english can get confused.

I'll be open to change that to `while` just to make it friendlier to international readers.
msg312648 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2018-02-23 17:11
Agree with Marietta: it's valid, but lets change it to make it more approachable to non-native speakers.
msg312650 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2018-02-23 17:24
> lets change it to make it more approachable to non-native speakers.

Sounds good to me.
msg312653 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2018-02-23 17:51
New changeset 98f42aac23f3863973cb6e9964c5212cfd3a1d98 by Mariatta in branch 'master':
bpo-32923: Unittest doc: replace `whilst` with `while` (GH-5833)
https://github.com/python/cpython/commit/98f42aac23f3863973cb6e9964c5212cfd3a1d98
msg312657 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2018-02-23 18:04
Thanks! I've fixed it on master, the backports have been initiated and will finish automatically.
msg312659 - (view) Author: miss-islington (miss-islington) Date: 2018-02-23 18:14
New changeset 1ad6ca5eb95ebb7351e0f5d9ce607dec54de6407 by Miss Islington (bot) in branch '3.7':
bpo-32923: Unittest doc: replace `whilst` with `while` (GH-5833)
https://github.com/python/cpython/commit/1ad6ca5eb95ebb7351e0f5d9ce607dec54de6407
msg312660 - (view) Author: miss-islington (miss-islington) Date: 2018-02-23 18:16
New changeset 8a7f1f4b0ffddf230864ebf16b481546970dd9c2 by Miss Islington (bot) in branch '2.7':
bpo-32923: Unittest doc: replace `whilst` with `while` (GH-5833)
https://github.com/python/cpython/commit/8a7f1f4b0ffddf230864ebf16b481546970dd9c2
msg312661 - (view) Author: miss-islington (miss-islington) Date: 2018-02-23 18:22
New changeset cffe0467ab7b164739693598826bd3860f01b11f by Miss Islington (bot) in branch '3.6':
bpo-32923: Unittest doc: replace `whilst` with `while` (GH-5833)
https://github.com/python/cpython/commit/cffe0467ab7b164739693598826bd3860f01b11f
History
Date User Action Args
2018-02-23 18:22:29miss-islingtonsetmessages: + msg312661
2018-02-23 18:16:58miss-islingtonsetmessages: + msg312660
2018-02-23 18:14:25miss-islingtonsetnosy: + miss-islington
messages: + msg312659
2018-02-23 18:04:45Mariattasetstatus: open -> closed
resolution: fixed
messages: + msg312657

stage: patch review -> resolved
2018-02-23 17:54:23miss-islingtonsetpull_requests: + pull_request5615
2018-02-23 17:53:22miss-islingtonsetpull_requests: + pull_request5614
2018-02-23 17:52:28miss-islingtonsetpull_requests: + pull_request5613
2018-02-23 17:51:15Mariattasetmessages: + msg312653
2018-02-23 17:24:46mark.dickinsonsetmessages: + msg312650
2018-02-23 17:21:45Mariattasetkeywords: + patch
stage: patch review
pull_requests: + pull_request5611
2018-02-23 17:11:41eric.smithsetnosy: + eric.smith
messages: + msg312648
2018-02-23 16:49:41Mariattasetnosy: + Mariatta

messages: + msg312644
versions: + Python 2.7, Python 3.7, Python 3.8
2018-02-23 16:20:50mark.dickinsonsetnosy: + mark.dickinson
messages: + msg312638
2018-02-23 15:30:12Тимофей Хирьяновcreate