➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2018-01-27 16:03 by xiang.zhang, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 5405 | merged | xiang.zhang, 2018-01-29 02:34 | |
| Messages (8) | |||
|---|---|---|---|
| msg310866 - (view) | Author: Xiang Zhang (xiang.zhang) *  |
Date: 2018-01-27 16:03 | |
I find one line[1] is weirdly commented out. But I don't think profile here is any different with trace. In 2.7, this line is not commented out and the change happens in b94767ff, fixing clang warnings. |
|||
| msg310868 - (view) | Author: Xiang Zhang (xiang.zhang) * |
Date: 2018-01-27 16:12 | |
Sorry, forget links, it's https://github.com/python/cpython/blob/master/Python/ceval.c#L3528 , and the commit is b94767ff44edf5d461d7cb1c8eb5160f83886358. |
|||
| msg310877 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2018-01-27 18:50 | |
I don't remember why that line was commented out to make the analyzer happy. |
|||
| msg310950 - (view) | Author: Xiang Zhang (xiang.zhang) * |
Date: 2018-01-28 14:53 | |
Ahh, I figure out that the line is useless and can't affect any logic then. So the analyzer is right! Sorry for the bother Brett. |
|||
| msg310990 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2018-01-28 21:01 | |
We should probably delete the line regardless so no one else gets thrown by this (or at least leave a comment). |
|||
| msg311044 - (view) | Author: Xiang Zhang (xiang.zhang) * |
Date: 2018-01-29 03:32 | |
New changeset 997478eb797b31bd724135ca17781d1cf4b89cfa by Xiang Zhang in branch 'master': bpo-32688: Make why the line is commented out clear (GH-5405) https://github.com/python/cpython/commit/997478eb797b31bd724135ca17781d1cf4b89cfa |
|||
| msg311045 - (view) | Author: Xiang Zhang (xiang.zhang) * |
Date: 2018-01-29 03:32 | |
Done. |
|||
| msg311050 - (view) | Author: Brett Cannon (brett.cannon) * |
Date: 2018-01-29 03:52 | |
Thanks! On Sun, Jan 28, 2018, 19:32 Xiang Zhang, <report@bugs.python.org> wrote: > > Xiang Zhang <angwerzx@126.com> added the comment: > > Done. > > ---------- > versions: -Python 3.6 > > _______________________________________ > Python tracker <report@bugs.python.org> > <https://bugs.python.org/issue32688> > _______________________________________ > |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:57 | admin | set | github: 76869 |
| 2018-01-29 03:52:21 | brett.cannon | set | messages: + msg311050 |
| 2018-01-29 03:32:37 | xiang.zhang | set | messages:
+ msg311045 versions: - Python 3.6 |
| 2018-01-29 03:32:14 | xiang.zhang | set | messages: + msg311044 |
| 2018-01-29 02:34:25 | xiang.zhang | set | pull_requests: + pull_request5238 |
| 2018-01-28 21:01:54 | brett.cannon | set | messages: + msg310990 |
| 2018-01-28 14:53:07 | xiang.zhang | set | status: open -> closed resolution: not a bug messages: + msg310950 stage: resolved |
| 2018-01-27 18:50:59 | brett.cannon | set | messages: + msg310877 |
| 2018-01-27 16:12:40 | xiang.zhang | set | messages: + msg310868 |
| 2018-01-27 16:03:53 | xiang.zhang | create | |