This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_zlib improve version parsing
Type: Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: open Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, pmpp, zach.ware
Priority: normal Keywords: patch

Created on 2018-01-26 15:55 by pmpp, last changed 2022-04-11 14:58 by admin.

Pull Requests
URL Status Linked Edit
PR 5347 merged pmpp, 2018-01-26 16:03
PR 5751 merged miss-islington, 2018-02-19 03:46
PR 5752 merged miss-islington, 2018-02-19 03:48
PR 22361 open pmpp, 2020-09-22 13:19
Messages (4)
msg310773 - (view) Author: pmp-p (pmpp) * Date: 2018-01-26 15:55
On some OS like android 4.0+, system libz.so gives funny versions number that prevent test_zlib from correctly parse it from zlib.ZLIB_RUNTIME_VERSION

https://patch-diff.githubusercontent.com/raw/vstinner/cpython/pull/1.patch

seems to fix "1.2.8-linuxfoundation-mods-v1" and "1.2.8.f-linuxfoundation-mods-v1" cases as already encountered on an popular operating system and maybe others yet unknown.
msg312337 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2018-02-19 03:45
New changeset 4c7108a77144493d0aa6fc0105b67d3797e143f5 by Zachary Ware (pmp-p) in branch 'master':
bpo-32682: Improve libz version parsing in test_zilb (GH-5347)
https://github.com/python/cpython/commit/4c7108a77144493d0aa6fc0105b67d3797e143f5
msg312339 - (view) Author: miss-islington (miss-islington) Date: 2018-02-19 04:10
New changeset 0cd35817e8278588f04dc574f6eca53273799f25 by Miss Islington (bot) in branch '3.7':
bpo-32682: Improve libz version parsing in test_zilb (GH-5347)
https://github.com/python/cpython/commit/0cd35817e8278588f04dc574f6eca53273799f25
msg312340 - (view) Author: miss-islington (miss-islington) Date: 2018-02-19 04:31
New changeset b0fd935360e81b6bb4733deed69f51516c771f7a by Miss Islington (bot) in branch '3.6':
bpo-32682: Improve libz version parsing in test_zilb (GH-5347)
https://github.com/python/cpython/commit/b0fd935360e81b6bb4733deed69f51516c771f7a
History
Date User Action Args
2022-04-11 14:58:57adminsetstatus: pending -> open
github: 76863
2020-11-08 11:31:46pmppsetstatus: closed -> pending
2020-09-22 13:19:17pmppsetpull_requests: + pull_request21399
2018-02-19 04:31:17miss-islingtonsetmessages: + msg312340
2018-02-19 04:20:47pmppsetstatus: open -> closed
resolution: fixed
stage: commit review -> resolved
2018-02-19 04:10:01miss-islingtonsetnosy: + miss-islington
messages: + msg312339
2018-02-19 03:56:10zach.waresetstage: patch review -> commit review
versions: + Python 3.6, Python 3.8
2018-02-19 03:48:19miss-islingtonsetpull_requests: + pull_request5528
2018-02-19 03:46:21miss-islingtonsetpull_requests: + pull_request5527
2018-02-19 03:45:14zach.waresetnosy: + zach.ware
messages: + msg312337
2018-01-26 16:03:00pmppsetkeywords: + patch
stage: patch review
pull_requests: + pull_request5195
2018-01-26 15:55:24pmppcreate