➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2018-01-16 11:12 by David Carlier, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 5202 | David Carlier, 2018-01-16 11:12 | ||
| Messages (6) | |||
|---|---|---|---|
| msg310078 - (view) | Author: David Carlier (David Carlier) * | Date: 2018-01-16 11:13 | |
Might brings a bit of "controversy" but some oses have already unoptimizable memset like functions from their libc was thinking to just use them instead. |
|||
| msg310079 - (view) | Author: David Carlier (David Carlier) * | Date: 2018-01-16 11:17 | |
Since the PR had been closed. |
|||
| msg310080 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2018-01-16 11:17 | |
Thanks for your contribution. Any optimization must land in upstream first, https://github.com/BLAKE2/libb2. See https://bugs.python.org/issue17405 for more discussion on the topic. |
|||
| msg310081 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2018-01-16 11:21 | |
In general your patch is a good idea. It should land in upstream, so everybody benefits from it. I also want to keep the maintenance burden as small as possible. |
|||
| msg310082 - (view) | Author: David Carlier (David Carlier) * | Date: 2018-01-16 11:23 | |
No worries If I saw first it was an extra project I would not have try to submit in Cpython. Apologies. I ll see what I can do in blake2 side :-) |
|||
| msg314523 - (view) | Author: David CARLIER (devnexen) * | Date: 2018-03-27 12:03 | |
Little update it has been accepted and merged today : https://github.com/BLAKE2/libb2/commit/620681a3b15c4d7239b9323b9da5ea208a959d3d |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:56 | admin | set | github: 76750 |
| 2018-03-27 12:03:34 | devnexen | set | nosy:
+ devnexen messages: + msg314523 |
| 2018-01-16 11:23:52 | David Carlier | set | messages: + msg310082 |
| 2018-01-16 11:21:58 | christian.heimes | set | messages: + msg310081 |
| 2018-01-16 11:17:29 | christian.heimes | set | nosy:
+ christian.heimes messages: + msg310080 |
| 2018-01-16 11:17:17 | David Carlier | set | status: open -> closed resolution: wont fix messages: + msg310079 stage: resolved |
| 2018-01-16 11:13:52 | David Carlier | set | messages: + msg310078 |
| 2018-01-16 11:12:26 | David Carlier | create | |