This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Possible issue in multiprocessing doc
Type: behavior Stage: resolved
Components: Documentation Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: 1a1a11a, berker.peksag, docs@python
Priority: normal Keywords: easy, patch

Created on 2017-11-16 17:27 by 1a1a11a, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 4469 merged 1a1a11a, 2017-11-19 18:50
PR 4577 merged python-dev, 2017-11-27 01:18
Messages (7)
msg306389 - (view) Author: Jason (1a1a11a) * Date: 2017-11-16 17:27
in multiprocessing doc https://docs.python.org/3.6/library/multiprocessing.html

under 17.2.2.7.2. Using a remote manager, 
>>> from multiprocessing.managers import BaseManager
>>> import queue
>>> queue = queue.Queue()
>>> class QueueManager(BaseManager): pass
>>> QueueManager.register('get_queue', callable=lambda:queue)
>>> m = QueueManager(address=('', 50000), authkey=b'abracadabra')
>>> s = m.get_server()
>>> s.serve_forever()


queue is used as both module name and variable name, should this be avoided?
msg306408 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2017-11-17 04:39
The example itself works fine, but I agree that it would be better to use a better name. We could replace ``('foo.bar.org', 50000)`` in the following examples with ``('', 50000)`` too.

Would you like to send a PR? The documentation file is located at Doc/library/multiprocessing.rst.
msg306409 - (view) Author: Jason (1a1a11a) * Date: 2017-11-17 04:43
Thank you for answering!
Yes, I would be very happy to do that, this is going to be my first contribution! :)
msg306509 - (view) Author: Jason (1a1a11a) * Date: 2017-11-19 18:58
Hi Berker, 
   I didn't update "following examples with ``('', 50000)`` too." because this is different than the previous one, this is client connecting to server, so hostname cannot be empty string.
msg307030 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2017-11-27 01:18
New changeset c172fc5031a4035986bef0b2fcef906706d7abf3 by Berker Peksag (Jason Yang) in branch 'master':
bpo-32051: Fix name shadowing in multiprocessing docs (GH-4469)
https://github.com/python/cpython/commit/c172fc5031a4035986bef0b2fcef906706d7abf3
msg307031 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2017-11-27 01:22
New changeset 8a957534f5182022ee8ac2dbaac4b4900dc98159 by Berker Peksag (Miss Islington (bot)) in branch '3.6':
bpo-32051: Fix name shadowing in multiprocessing docs (GH-4469)
https://github.com/python/cpython/commit/8a957534f5182022ee8ac2dbaac4b4900dc98159
msg307032 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2017-11-27 01:23
Thanks!
History
Date User Action Args
2022-04-11 14:58:54adminsetgithub: 76232
2017-11-27 01:23:18berker.peksagsetstatus: open -> closed
resolution: fixed
messages: + msg307032

stage: patch review -> resolved
2017-11-27 01:22:53berker.peksagsetmessages: + msg307031
2017-11-27 01:18:49python-devsetpull_requests: + pull_request4505
2017-11-27 01:18:37berker.peksagsetmessages: + msg307030
2017-11-19 18:58:201a1a11asetmessages: + msg306509
2017-11-19 18:50:471a1a11asetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request4401
2017-11-17 04:43:141a1a11asetmessages: + msg306409
2017-11-17 04:39:55berker.peksagsettype: enhancement -> behavior
versions: + Python 3.7
keywords: + easy
nosy: + berker.peksag

messages: + msg306408
stage: needs patch
2017-11-16 17:27:041a1a11acreate