This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Module-level pickle tests test only default implementation
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: serhiy.storchaka
Priority: normal Keywords: patch

Created on 2017-11-15 10:10 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 4401 merged serhiy.storchaka, 2017-11-15 10:12
PR 4403 merged python-dev, 2017-11-15 12:01
Messages (3)
msg306260 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-11-15 10:10
In Python 2 tests for module-level API test both implementations, pickle and cPickle. In Python 3 they test only the default implementation. If _pickle is available, the Python implementation of module-level functions is not tested.
msg306264 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-11-15 12:01
New changeset 6545256df93ba54f811206107274cfa5a6d76b86 by Serhiy Storchaka in branch 'master':
bpo-32032: Test both implementations of module-level pickle API. (#4401)
https://github.com/python/cpython/commit/6545256df93ba54f811206107274cfa5a6d76b86
msg306267 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-11-15 12:32
New changeset eb38367f20b05f2ad04a4833bceb369b5e78b1a3 by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6':
bpo-32032: Test both implementations of module-level pickle API. (GH-4401) (#4403)
https://github.com/python/cpython/commit/eb38367f20b05f2ad04a4833bceb369b5e78b1a3
History
Date User Action Args
2022-04-11 14:58:54adminsetgithub: 76213
2017-11-15 14:08:34serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-11-15 12:32:07serhiy.storchakasetmessages: + msg306267
2017-11-15 12:01:22python-devsetpull_requests: + pull_request4352
2017-11-15 12:01:13serhiy.storchakasetmessages: + msg306264
2017-11-15 10:12:29serhiy.storchakasetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request4350
2017-11-15 10:10:18serhiy.storchakacreate