This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_zipapp failed when the zlib module is not available
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: paul.moore, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2017-11-10 09:25 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 4358 merged serhiy.storchaka, 2017-11-10 09:31
Messages (3)
msg306009 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-11-10 09:25
http://buildbot.python.org/all/#/builders/14/builds/160/steps/4/logs/stdio
======================================================================
ERROR: test_create_archive_with_compression (test.test_zipapp.ZipAppTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.billenstein-sierra/build/Lib/test/test_zipapp.py", line 111, in test_create_archive_with_compression
    zipapp.create_archive(source, target, compressed=True)
  File "/Users/buildbot/buildarea/3.x.billenstein-sierra/build/Lib/zipapp.py", line 138, in create_archive
    with zipfile.ZipFile(fd, 'w', compression=compression) as z:
  File "/Users/buildbot/buildarea/3.x.billenstein-sierra/build/Lib/zipfile.py", line 1061, in __init__
    _check_compression(compression)
  File "/Users/buildbot/buildarea/3.x.billenstein-sierra/build/Lib/zipfile.py", line 644, in _check_compression
    "Compression requires the (missing) zlib module")
RuntimeError: Compression requires the (missing) zlib module
----------------------------------------------------------------------
msg306013 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-11-10 10:09
New changeset a1718bc7e0455ec5019e800d4172947bb4a07962 by Serhiy Storchaka in branch 'master':
bpo-31998: Fix test_zipapp in case the zlib module is not available. (#4358)
https://github.com/python/cpython/commit/a1718bc7e0455ec5019e800d4172947bb4a07962
msg306015 - (view) Author: Paul Moore (paul.moore) * (Python committer) Date: 2017-11-10 10:12
Good catch, thanks Serhiy!
History
Date User Action Args
2022-04-11 14:58:54adminsetgithub: 76179
2017-11-10 10:18:29serhiy.storchakasetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
versions: - Python 3.6
2017-11-10 10:12:30paul.mooresetmessages: + msg306015
2017-11-10 10:09:29serhiy.storchakasetmessages: + msg306013
2017-11-10 09:31:22serhiy.storchakasetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request4313
2017-11-10 09:25:52serhiy.storchakacreate