This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: docs for email.generator are missing a comment on special multipart/signed handling
Type: enhancement Stage: resolved
Components: email Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: barry, dhke, miss-islington, r.david.murray
Priority: normal Keywords: patch

Created on 2017-10-27 17:23 by dhke, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
email-generator-multipart-signed-docs.patch dhke, 2017-10-27 17:23 proposed documentation update review
Pull Requests
URL Status Linked Edit
PR 4268 merged python-dev, 2017-11-04 06:23
Messages (3)
msg305127 - (view) Author: Peter Wullinger (dhke) * Date: 2017-10-27 17:23
The documentation for email.generator.{Bytes,}Generator do not mention that Generator._handle_multipart_signed() exists and disables header folding for subparts of multipart/signed.

This may cause some frustration, since, as implemented, rendering a message part enclosed in multipart/signed causes headers to fold differently than rendering the respective message part individually:

>>> text = MIMEText('', 'plain', 'utf-8')
>>> text['X-X'] = 'a b c d e f g h i j k l m n o p q r s t u v w x y z a b c d e f g h i j k l m n o p'
>>> print(text.as_string())
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
X-X: a b c d e f g h i j k l m n o p q r s t u v w x y z a b c d e f g h i j k
 l m n o p


>>> signed = MIMEMultipart('signed', filename='smime.p7s')
>>> signed.attach(text)
>>> print(signed.as_string())
Content-Type: multipart/signed; filename="smime.p7s";
 boundary="===============8046244967080646804=="
MIME-Version: 1.0

--===============8046244967080646804==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
X-X: a b c d e f g h i j k l m n o p q r s t u v w x y z a b c d e f g h i j k l m n o p


--===============8046244967080646804==--

This breaks SMIME signatures when using the partial render to generate the signature. 

A possible workaround is to set maxheaderlen=0 for the partial render, which is the same as what Generator._handle_multipart_signed() does, but to do that one needs to know about the special processing.

Attached is a suggestion at a documentation fix that remedies this problem at least for the online docs.
msg305130 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2017-10-27 17:52
The patch looks good to me if someone wants to make a PR out of it.  If you wouldn't mind digitally signing the CLA, Peter, that would make PSF legal happy, though I doubt a one sentence doc patch is really an issue.
msg329268 - (view) Author: miss-islington (miss-islington) Date: 2018-11-04 22:12
New changeset 622935d9a69d12e125e470ce9a9ff3cad9e8e296 by Miss Islington (bot) (Saptak Sengupta) in branch 'master':
bpo-31887: Adds documentations for special multipart/signed handling (GH-4268)
https://github.com/python/cpython/commit/622935d9a69d12e125e470ce9a9ff3cad9e8e296
History
Date User Action Args
2022-04-11 14:58:53adminsetgithub: 76068
2019-01-05 21:58:48cheryl.sabellasetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
versions: - Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7
2018-11-04 22:12:36miss-islingtonsetnosy: + miss-islington
messages: + msg329268
2017-11-04 06:23:55python-devsetstage: patch review
pull_requests: + pull_request4231
2017-10-27 17:52:48r.david.murraysetmessages: + msg305130
2017-10-27 17:23:47dhkecreate