➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-10-11 00:18 by snoeberger, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 3993 | merged | vyas45, 2017-10-14 07:17 | |
| PR 4005 | merged | python-dev, 2017-10-15 07:31 | |
| PR 4011 | closed | vyas45, 2017-10-16 17:21 | |
| PR 4012 | merged | vyas45, 2017-10-16 18:15 | |
| Messages (8) | |||
|---|---|---|---|
| msg304096 - (view) | Author: Robert Snoeberger (snoeberger) | Date: 2017-10-11 00:18 | |
The signature for PyBuffer_FillContiguousStrides in the documentation shows that the type of parameter 'itemsize' is Py_ssize_t [1]. This is different from the signature in Include/abstract.h which shows that the type as int [2]. [1] https://docs.python.org/3/c-api/buffer.html#c.PyBuffer_FillContiguousStrides [2] https://github.com/python/cpython/blob/49b2734bf12dc1cda80fd73d3ec8896ae3e362f2/Include/abstract.h#L559-L563 |
|||
| msg304355 - (view) | Author: Aniket Vyas (vyas45) * | Date: 2017-10-13 20:23 | |
Hello ! I am new to the community and would love to start my contribution here. Can I take up this bug ? In order to do so I am going through the following links: https://docs.python.org/devguide/docquality.html https://docs.python.org/devguide/pullrequest.html Is the list exhaustive for this particular issue ? Thanks ! |
|||
| msg304360 - (view) | Author: Mariatta (Mariatta) *  |
Date: 2017-10-13 20:54 | |
Welcome Aniket. Yes those two links are good starting points. Please propose a PR with the fix. |
|||
| msg304385 - (view) | Author: Aniket Vyas (vyas45) * | Date: 2017-10-14 07:29 | |
Thanks Mariatta. I have initiated a PR for the issue. https://github.com/python/cpython/pull/3993 |
|||
| msg304424 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2017-10-15 07:31 | |
New changeset 1b9e76ed3a055a53ca67397e928e1b408461900b by Berker Peksag (vyas45) in branch 'master': bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides (GH-3993) https://github.com/python/cpython/commit/1b9e76ed3a055a53ca67397e928e1b408461900b |
|||
| msg304425 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2017-10-15 07:37 | |
New changeset e881302b70ab36bafcf37e3917be118bbec97763 by Berker Peksag (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides (GH-3993) https://github.com/python/cpython/commit/e881302b70ab36bafcf37e3917be118bbec97763 |
|||
| msg304479 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2017-10-16 18:23 | |
New changeset 50cef52372381a9e2f3d760497d8db76254cffef by Berker Peksag (vyas45) in branch '2.7': [2.7] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides (GH-3993) https://github.com/python/cpython/commit/50cef52372381a9e2f3d760497d8db76254cffef |
|||
| msg304480 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2017-10-16 18:26 | |
Thank you for the report, Robert and thank you for the patches, Aniket. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:53 | admin | set | github: 75935 |
| 2017-10-16 18:26:06 | berker.peksag | set | status: open -> closed resolution: fixed messages: + msg304480 stage: patch review -> resolved |
| 2017-10-16 18:23:46 | berker.peksag | set | messages: + msg304479 |
| 2017-10-16 18:15:20 | vyas45 | set | pull_requests: + pull_request3986 |
| 2017-10-16 17:21:03 | vyas45 | set | stage: backport needed -> patch review pull_requests: + pull_request3985 |
| 2017-10-15 07:47:26 | berker.peksag | set | stage: patch review -> backport needed |
| 2017-10-15 07:37:09 | berker.peksag | set | messages: + msg304425 |
| 2017-10-15 07:34:44 | berker.peksag | set | type: behavior |
| 2017-10-15 07:31:45 | python-dev | set | pull_requests: + pull_request3978 |
| 2017-10-15 07:31:38 | berker.peksag | set | nosy:
+ berker.peksag messages: + msg304424 |
| 2017-10-14 07:29:47 | vyas45 | set | messages: + msg304385 |
| 2017-10-14 07:17:49 | vyas45 | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request3969 |
| 2017-10-13 20:54:50 | Mariatta | set | nosy:
+ Mariatta messages: + msg304360 |
| 2017-10-13 20:23:19 | vyas45 | set | nosy:
+ vyas45 messages: + msg304355 |
| 2017-10-11 08:45:47 | serhiy.storchaka | set | keywords:
+ easy stage: needs patch versions: + Python 2.7, Python 3.7 |
| 2017-10-11 00:18:47 | snoeberger | create | |