Issue 31713: python3 python-config script generates invalid includes

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/75894

classification

Title:	python3 python-config script generates invalid includes
Type:		Stage:	resolved
Components:	Cross-Build	Versions:	Python 3.4

process

Status:	closed	Resolution:	duplicate
Dependencies:		Superseder:	"python-config --includes" returns a wrong path (double prefix) View: 22140
Assigned To:		Nosy List:	Alex.Willmer, matthewlweber
Priority:	normal	Keywords:	patch

Created on 2017-10-06 13:37 by matthewlweber, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name	Uploaded	Description	Edit
0029-python-config.sh-don-t-reassign-prefix.patch	matthewlweber, 2017-10-06 17:48

Messages (1)
msg303819 - (view)	Author: (matthewlweber)	Date: 2017-10-06 13:37
Related to https://bugs.python.org/issue22907 If building in a path that starts with /usr, the includedir=$(echo "@includedir@" \| sed "s#^$prefix_build#$prefix_real#") assignment in the python-config.sh ends up having the path it processes ran through a path substitution once before this line is executed because the @includedir@ in the python-config.sh.in is set to the string '${prefix}/include'. ${prefix} is assigned just above includedir in python-config.sh to prefix=$(echo "$prefix_build" \| sed "s#^$prefix_build#$prefix_real#") I believe we need to update the includedir to includedir=$(echo "@includedir@") Or rename the prefix variable in python-config.sh so that there isn't a naming conflict if a string is passed in via @includedir@ with that variable. Without fixing this you end up with multiple /usr substitutions in the includedir string, each replaced with the real path. ie resulting in an invalid path.

msg303819 - (view)

Author: (matthewlweber)

Date: 2017-10-06 13:37

Related to https://bugs.python.org/issue22907

If building in a path that starts with /usr, the includedir=$(echo "@includedir@" | sed "s#^$prefix_build#$prefix_real#") assignment in the python-config.sh ends up having the path it processes ran through a path substitution once before this line is executed because the @includedir@ in the python-config.sh.in is set to the string '${prefix}/include'.  ${prefix} is assigned just above includedir in python-config.sh to prefix=$(echo "$prefix_build" | sed "s#^$prefix_build#$prefix_real#")

I believe we need to update the includedir to 

includedir=$(echo "@includedir@")

Or rename the prefix variable in python-config.sh so that there isn't a naming conflict if a string is passed in via @includedir@ with that variable.

Without fixing this you end up with multiple /usr substitutions in the includedir string, each replaced with the real path.  ie resulting in an invalid path.

History
Date	User	Action	Args
2022-04-11 14:58:53	admin	set	github: 75894
2020-11-27 14:00:05	iritkatriel	set	status: open -> closed superseder: "python-config --includes" returns a wrong path (double prefix) resolution: duplicate stage: resolved
2017-10-06 17:48:03	matthewlweber	set	files: + 0029-python-config.sh-don-t-reassign-prefix.patch keywords: + patch
2017-10-06 13:37:29	matthewlweber	create