classification
Title: zipapp module should support compression
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: paul.moore Nosy List: merwok, paul.moore, zmwangx
Priority: normal Keywords: needs review, patch

Created on 2017-09-29 11:12 by zmwangx, last changed 2017-09-29 17:37 by paul.moore. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 3819 merged zmwangx, 2017-09-29 11:18
Messages (3)
msg303323 - (view) Author: Zhiming Wang (zmwangx) * Date: 2017-09-29 11:12
Currently (up to 3.7.0a1) archives generated by the zipapp module are uncompressed, which are unnecessarily large for large projects. It's easy to add deflate compression support, and Python loads compressed archives just fine.

I already have a patch available. I'll submit a PR soon.
msg303343 - (view) Author: Paul Moore (paul.moore) * (Python committer) Date: 2017-09-29 17:05
Definitely. The reason it uses uncompressed files is simply an oversight on my part - I hadn't realised the default for zipfile was uncompressed.
msg303345 - (view) Author: Paul Moore (paul.moore) * (Python committer) Date: 2017-09-29 17:31
New changeset d87b105ca794addf92addb28293c92a7ef4141e1 by Paul Moore (Zhiming Wang) in branch 'master':
bpo-31638: Add compression support to zipapp (GH-3819)
https://github.com/python/cpython/commit/d87b105ca794addf92addb28293c92a7ef4141e1
History
Date User Action Args
2017-09-29 17:37:11paul.mooresetstatus: open -> closed
assignee: paul.moore
resolution: fixed
stage: patch review -> resolved
2017-09-29 17:31:54paul.mooresetmessages: + msg303345
2017-09-29 17:05:36paul.mooresetmessages: + msg303343
2017-09-29 16:27:13merwoksetkeywords: + needs review
nosy: + paul.moore

versions: - Python 3.8
2017-09-29 16:15:30merwoksetnosy: + merwok
2017-09-29 11:18:22zmwangxsetkeywords: + patch
stage: patch review
pull_requests: + pull_request3803
2017-09-29 11:12:16zmwangxcreate