classification
Title: Allow to build MSI installer from the official tarball
Type: enhancement Stage:
Components: Build, Windows Versions: Python 3.4
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Ivan.Pozdeev, __Vano, larry, paul.moore, r.david.murray, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2017-09-29 01:01 by Ivan.Pozdeev, last changed 2017-10-04 16:37 by zach.ware.

Files
File name Uploaded Description Edit
0001-Support-making-MSI-installer-from-tarball.patch Ivan.Pozdeev, 2017-09-29 01:42 patch against 3.4
Messages (7)
msg303292 - (view) Author: Ivan Pozdeev (Ivan.Pozdeev) * Date: 2017-09-29 01:01
Since the last version of 3.4 is only made available as a source tarball, it's imperative to be able to make a distributable package locally from it. Tools/msi/msi.py only works from an `hg' checkout.
msg303294 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2017-09-29 01:11
Assuming 3.4 is packagable using msi and hg is the only problem, I presume you could use an hg-git adapter to get an hg checkout to build from.
msg303295 - (view) Author: Ivan Pozdeev (Ivan.Pozdeev) * Date: 2017-09-29 01:52
With this patch, I managed to make a working installer.

There's nothing in PCBuild/readme.txt about making an installer, and this is the only relevant tool I found in the source. If there's another, feel free to close the ticket, and I'll create another one to fix the readme.
msg303354 - (view) Author: Ivan Pozdeev (__Vano) Date: 2017-09-29 19:31
> Assuming 3.4 is packagable using msi and hg is the only problem, I presume you could use an hg-git adapter to get an hg checkout to build from.
An official source tarball, by definition, should be able to be built 
from itself, and contain tools for that. If I take sources from a Git 
repo instead, I'm not building from a tarball. If I must do some 
undocumented magic on the extracted source to build that tools don't do, 
the tools are broken. The current ticket and the attached patch fix the 
tools.

P.S. I didn't include the patch right away 'cuz I was going to make a 
PR. But GitHub doesn't work for me for some reason lately, so attached 
it here after tried and failed.
msg303649 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-10-03 21:33
As 3.4 is in security-fix-only mode, it's up to Larry whether this can be merged.  The patch looks fine as far as I can tell, but I can't test it.

Note, though, that you are likely to be the only person on Earth using this installer, since there will be no more binary releases of 3.4, the installer was swapped out for 3.5, and the maintainer of the old installer has been away for several years now.  The new installer (in use since 3.5.0) almost certainly doesn't suffer from this issue.
msg303708 - (view) Author: Ivan Pozdeev (__Vano) Date: 2017-10-04 16:19
> Note, though, that you are likely to be the only person on Earth 
using this installer, since there will be no more binary releases of 3.4

Since this is the last release for XP, probably the ppl who are stuck on 
this OS as well. An installable package is a must for any 
maintainability to speak of. The lack of a binary release is actually 
going to be a boost for its use, here :-)

I also had trouble discovering this script in the first place since it's 
not mentioned in PCBuild/readme.txt .
If build instructions are updated as per issue31691 , this would help 
potential users as well.

Beside this patch, issue31170 and issue31645 are needed for the 3.4 
build to work.
msg303709 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-10-04 16:37
If you're still on XP, security is obviously not a big concern and you're just as well off to stick with 3.4.4 :)
History
Date User Action Args
2017-10-04 16:37:05zach.waresetmessages: + msg303709
2017-10-04 16:19:08__Vanosetmessages: + msg303708
2017-10-03 21:33:05zach.waresetnosy: + larry
messages: + msg303649
2017-09-30 01:11:37terry.reedysetnosy: + paul.moore, tim.golden, zach.ware, steve.dower
components: + Windows
2017-09-29 19:31:12__Vanosetnosy: + __Vano
messages: + msg303354
2017-09-29 01:52:37Ivan.Pozdeevsetmessages: + msg303295
2017-09-29 01:43:33Ivan.Pozdeevsetnosy: + r.david.murray
2017-09-29 01:42:21Ivan.Pozdeevsetfiles: + 0001-Support-making-MSI-installer-from-tarball.patch
nosy: - r.david.murray
keywords: + patch
2017-09-29 01:11:03r.david.murraysetnosy: + r.david.murray
messages: + msg303294
2017-09-29 01:01:16Ivan.Pozdeevcreate