classification
Title: [2.7][3.6] test_socketserver ForkingMixIn tests leaks child processes on Python 3.6
Type: Stage: resolved
Components: Versions: Python 3.6, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: haypo
Priority: normal Keywords: patch

Created on 2017-09-26 13:47 by haypo, last changed 2017-09-27 10:24 by haypo. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 3766 merged haypo, 2017-09-26 13:49
PR 3786 merged haypo, 2017-09-27 09:32
Messages (3)
msg303040 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2017-09-26 13:47
The bpo-31151 (socketserver.ForkingMixIn.server_close() leaks zombie processes) was fixed in the master branch, but 2.7 and 3.6 branches were not changed.

I proposed to modify test_socketserver to explicitly waits until child processes complete. See attached PR.

Example of leaked child processes the on "x86 Gentoo Refleaks 3.6" buildbot:

http://buildbot.python.org/all/builders/x86%20Gentoo%20Refleaks%203.6/builds/102/steps/test/logs/stdio

0:26:11 load avg: 5.72 [ 62/405] test_socketserver passed -- running: test_multiprocessing_forkserver (594 sec)
beginning 6 repetitions
123456
Warning -- reap_children() reaped child process 6891
.Warning -- reap_children() reaped child process 6976
Warning -- reap_children() reaped child process 6981
.Warning -- reap_children() reaped child process 7059
.Warning -- reap_children() reaped child process 7136
..Warning -- reap_children() reaped child process 7306
.
msg303115 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2017-09-27 09:21
New changeset fdcf3e9629201ef725af629d99e02215a2d657c8 by Victor Stinner in branch '3.6':
bpo-31593: test_socketserver waits child processes (#3766)
https://github.com/python/cpython/commit/fdcf3e9629201ef725af629d99e02215a2d657c8
msg303120 - (view) Author: STINNER Victor (haypo) * (Python committer) Date: 2017-09-27 10:03
New changeset b4920d562b74e909bfae71bf119350a01d1d5e5e by Victor Stinner in branch '2.7':
bpo-31593: test_socketserver waits child processes (#3786)
https://github.com/python/cpython/commit/b4920d562b74e909bfae71bf119350a01d1d5e5e
History
Date User Action Args
2017-09-27 10:24:21hayposetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-09-27 10:03:01hayposetmessages: + msg303120
2017-09-27 09:32:09hayposetpull_requests: + pull_request3771
2017-09-27 09:21:15hayposetmessages: + msg303115
2017-09-26 13:49:59hayposetkeywords: + patch
stage: patch review
pull_requests: + pull_request3751
2017-09-26 13:49:44hayposettitle: test_socketserver ForkingMixIn tests leaks child processes -> [2.7][3.6] test_socketserver ForkingMixIn tests leaks child processes on Python 3.6
versions: + Python 2.7
2017-09-26 13:47:40haypocreate