classification
Title: Refactor the enumerate.__next__ implementation
Type: enhancement Stage: resolved
Components: Interpreter Core Versions: Python 3.7
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: rhettinger, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2017-09-26 05:27 by serhiy.storchaka, last changed 2017-10-24 12:51 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
enum_next.diff serhiy.storchaka, 2017-10-24 12:51
Pull Requests
URL Status Linked Edit
PR 3759 closed serhiy.storchaka, 2017-09-26 05:30
Messages (3)
msg303006 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-09-26 05:27
Currently the large and complex part of enum_next() and enum_next_long() in Objects/enumobject.c is duplicated. This increases the code size and makes harder maintaining the code. The proposed patch refactors the implementation and removes the code duplication.
msg303007 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2017-09-26 05:34
Having separate code paths was an intentional decision.  I prefer to keep it that way.
msg304908 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-10-24 12:51
Added a patch for history.
History
Date User Action Args
2017-10-24 12:51:13serhiy.storchakasetfiles: + enum_next.diff

messages: + msg304908
2017-09-26 05:34:27rhettingersetstatus: open -> closed
resolution: rejected
messages: + msg303007

stage: patch review -> resolved
2017-09-26 05:30:21serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request3745
2017-09-26 05:27:26serhiy.storchakacreate