msg301518 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-09-06 21:10 |
The --without-threads option has a lot of repercussions on the code base, forcing us to maintain specific paths for builds with threads disabled, for no useful purpose.
|
msg301520 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-09-06 21:12 |
See discussion in https://mail.python.org/pipermail/python-dev/2017-September/149156.html
|
msg301521 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-09-06 21:15 |
Question: should we keep Modules/Setup.config.in? It's going to become empty:
https://github.com/python/cpython/blob/master/Modules/Setup.config.in
|
msg301539 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2017-09-06 22:58 |
The PEP 11 should be updated just to mention that platforms without threading support are not supported in Python 3.7.
|
msg301543 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2017-09-06 23:23 |
We had a buildbot testing --without-threads, but it's gone. I just removed its unused class from the buildbot configuration:
https://github.com/python/buildmaster-config/commit/091f52aa05a8977966796ba3ef4b8257bef1c0e9
|
msg301559 - (view) |
Author: Gregory P. Smith (gregory.p.smith) * |
Date: 2017-09-07 00:50 |
I guess Setup.config.in can go. It's only purpose was for autoconf driven Setup changes.
|
msg301595 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2017-09-07 16:56 |
New changeset a6a4dc816d68df04a7d592e0b6af8c7ecc4d4344 by Victor Stinner (Antoine Pitrou) in branch 'master':
bpo-31370: Remove support for threads-less builds (#3385)
https://github.com/python/cpython/commit/a6a4dc816d68df04a7d592e0b6af8c7ecc4d4344
|
msg301596 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2017-09-07 16:58 |
PEP 11 was updated, the change was merged, this issue can now be closed. Thanks Antoine!
|
msg301805 - (view) |
Author: Arfrever Frehtes Taifersar Arahesis (Arfrever) * |
Date: 2017-09-10 09:04 |
Also 'import threading' code in Tools/scripts/run_tests.py should be cleaned.
|
msg301964 - (view) |
Author: Arfrever Frehtes Taifersar Arahesis (Arfrever) * |
Date: 2017-09-12 15:46 |
Lib/_dummy_thread.py and Lib/dummy_threading.py were deleted, but Doc/library/_dummy_thread.rst and Doc/library/dummy_threading.rst still exist.
Probably Doc/whatsnew/3.7.rst should mention that these modules were deleted.
Or maybe they should be restored and firstly deprecated, before deletion in a later version of Python.
|
msg301968 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2017-09-12 16:01 |
Arfrever: "Lib/_dummy_thread.py and Lib/dummy_threading.py were deleted, but Doc/library/_dummy_thread.rst and Doc/library/dummy_threading.rst still exist."
Ah, it should be deleted as well.
Arfrever: "Probably Doc/whatsnew/3.7.rst should mention that these modules were deleted."
Right.
Arfrever: "Or maybe they should be restored and firstly deprecated, before deletion in a later version of Python."
I don't think that it's worth it, but I suggest to add a warning to Python 3.6 documentation. Something like the following warning in Python 2.7 documentation of the commands module:
"Deprecated since version 2.6: The commands module has been removed in Python 3. Use the subprocess module instead."
https://docs.python.org/2/library/commands.html
|
msg301971 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2017-09-12 16:12 |
Oh, Arfrever wrote me on IRC that the removal of dummy_threading broke portage on Gentoo: https://bugs.gentoo.org/630730
eventlet also uses dummy_threading:
eventlet/support/dns/entropy.py:23: import dummy_threading as _threading
eventlet/support/dns/resolver.py:29: import dummy_threading as _threading
Hum, maybe we need one release with the deprecated module, and only remove it in Python 3.8?
|
msg301973 - (view) |
Author: Christian Heimes (christian.heimes) * |
Date: 2017-09-12 16:23 |
+1 to restore dummy_threading and go through a proper deprecation phase in 3.7+.
-0 to restore _dummy_thread. It's an internal, private module.
|
msg301980 - (view) |
Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-09-12 17:20 |
Following lines needs updating:
Lib/importlib/_bootstrap.py:1135
Lib/_pydecimal.py:436
Lib/test/ssl_servers.py:11
Lib/test/support/__init__.py:2053
Lib/test/test_httplib.py:1080
Lib/test/test_idle.py:4
Lib/test/test_multiprocessing_main_handling.py:3
Lib/test/test_thread.py:5
Lib/test/test_threadsignals.py:8
Lib/test/test_tools/test_sundry.py:43
Lib/test/test_winreg.py:7
Lib/test/test_wsgiref.py:256
Lib/test/test_xmlrpc.py:1179
|
msg301987 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2017-09-12 18:28 |
dummy_threading should definitely not have been removed, and like all the other APIs should not be removed until 2.7 is dead. Deprecating it is of course fine :)
|
msg301988 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2017-09-12 18:31 |
And actually, I wouldn't be surprised if eventlet depended on the *functionality* in _dummy_threading, so you probably need to restore that, too.
|
msg302474 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-09-18 16:35 |
> eventlet also uses dummy_threading
Not sure what you mean by that. eventlet uses the regular try/except import dance around "import threading":
https://github.com/eventlet/eventlet/blob/master/eventlet/support/dns/entropy.py#L20-L23
https://github.com/eventlet/eventlet/blob/master/eventlet/support/dns/resolver.py#L23-L26
As for portage, Arfrever fixed it :-)
https://gitweb.gentoo.org/proj/portage.git/commit/?id=504f66b0e25281e4465ebeceb799c3e54ff2b884
That said, I am not against bringing dummy_threading back, though it would sound rather weird to use it unconditionally...
|
msg302476 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-09-18 17:21 |
https://github.com/python/cpython/pull/3648 restores dummy_threading and _dummy_thread, but deprecates them.
|
msg302484 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-09-18 20:04 |
New changeset b43c4caf81b10e5c7ebaeb3a712c6db584f60bbd by Antoine Pitrou in branch 'master':
Restore dummy_threading and _dummy_thread, but deprecate them (bpo-31370) (#3648)
https://github.com/python/cpython/commit/b43c4caf81b10e5c7ebaeb3a712c6db584f60bbd
|
msg302492 - (view) |
Author: Antoine Pitrou (pitrou) * |
Date: 2017-09-18 21:50 |
New changeset 88c60c9668f0aa732693517a60b851cc1dfce0cb by Antoine Pitrou in branch 'master':
Trivial cleanups following bpo-31370 (#3649)
https://github.com/python/cpython/commit/88c60c9668f0aa732693517a60b851cc1dfce0cb
|
msg326681 - (view) |
Author: Brian Curtin (brian.curtin) * |
Date: 2018-09-29 16:07 |
New changeset eef059657d6b10babdb4831e1148d60cc644ee9a by Brian Curtin (Zackery Spytz) in branch 'master':
bpo-31370: Remove references to threadless builds (#8805)
https://github.com/python/cpython/commit/eef059657d6b10babdb4831e1148d60cc644ee9a
|
msg348490 - (view) |
Author: kb1000 (kb1000) * |
Date: 2019-07-26 13:14 |
Unfortunately, this also leads to less good LTO if you use a single static executable, similar to what Tools/freeze produces but including libpython itself. I'm currently trying to make LLVM do that, but since I can't build without threads, it'd be extremely hard to tell it that it can remove all threading related things (like TLS) and inline them. This means I'll have to patch CPython on my own to remove thread support, but unfortunately this also means I can't guarantee that it continues to work, as well as that it makes it a lot more likely that my build won't support many third-party libraries.
|
msg408243 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2021-12-10 18:42 |
This has unfortunately turned out to be a blocker on getting WASI support as there's not direct threading support in WebAssembly.
|
msg408257 - (view) |
Author: Gregory P. Smith (gregory.p.smith) * |
Date: 2021-12-10 23:14 |
https://web.dev/webassembly-threads/ suggests otherwise.
|
msg408501 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2021-12-13 23:59 |
> https://web.dev/webassembly-threads/ suggests otherwise.
It actually doesn't as that post isn't for WASI, it's for WASM in the browser (I chose my acronyms carefully 😉).
WASI is like POSIX for WebAssembly, so it's meant for desktop usage and thus no browser or JS engine is involved to provide web workers.
|
msg408508 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2021-12-14 01:06 |
> This has unfortunately turned out to be a blocker on getting WASI support as there's not direct threading support in WebAssembly.
This issue is now closed and unrelated to WASI support. Can you please open a new separated issue for it?
|
msg408518 - (view) |
Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-12-14 09:31 |
Concur with Victor. It is fine to add a link to other discussion in a closed issue, but an issue closed many years ago is not a good place for a new discussion at all.
|
msg408575 - (view) |
Author: Brett Cannon (brett.cannon) * |
Date: 2021-12-14 22:59 |
I am not opening a new discussion; this is just recording this fact here as it has come up in other places on the internet.
|
msg408594 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2021-12-15 11:18 |
Either reopen the issue or open a new issue. Only people subscribed to this bug are aware of the recent comments. Closed issues are hidden from the bugs home page and from the default search.
If you consider that Python must again support thread-less platforms, IMO it's a new feature and a new issue must be opened.
|
|
Date |
User |
Action |
Args |
2022-04-11 14:58:52 | admin | set | github: 75551 |
2022-03-09 09:35:58 | vstinner | set | nosy:
- vstinner
|
2022-03-04 10:35:29 | pmpp | set | nosy:
+ pmpp
|
2021-12-15 11:18:36 | vstinner | set | messages:
+ msg408594 |
2021-12-14 22:59:44 | brett.cannon | set | messages:
+ msg408575 |
2021-12-14 09:31:42 | serhiy.storchaka | set | messages:
+ msg408518 |
2021-12-14 01:06:34 | vstinner | set | messages:
+ msg408508 |
2021-12-13 23:59:35 | brett.cannon | set | messages:
+ msg408501 |
2021-12-10 23:14:14 | gregory.p.smith | set | messages:
+ msg408257 |
2021-12-10 18:42:21 | brett.cannon | set | nosy:
+ brett.cannon messages:
+ msg408243
|
2019-07-26 13:14:44 | kb1000 | set | nosy:
+ kb1000 messages:
+ msg348490
|
2018-09-29 16:07:19 | brian.curtin | set | nosy:
+ brian.curtin messages:
+ msg326681
|
2018-08-18 12:42:04 | ZackerySpytz | set | pull_requests:
+ pull_request8282 |
2017-11-03 06:42:40 | berker.peksag | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
2017-11-03 06:42:11 | berker.peksag | set | messages:
- msg302490 |
2017-09-18 21:50:45 | pitrou | set | messages:
+ msg302492 |
2017-09-18 21:05:40 | Steve Gomez | set | nosy:
+ Steve Gomez messages:
+ msg302490
|
2017-09-18 20:04:27 | pitrou | set | messages:
+ msg302484 |
2017-09-18 17:35:25 | pitrou | set | stage: resolved -> patch review pull_requests:
+ pull_request3642 |
2017-09-18 17:21:41 | pitrou | set | messages:
+ msg302476 stage: patch review -> resolved |
2017-09-18 17:20:23 | pitrou | set | keywords:
+ patch stage: resolved -> patch review pull_requests:
+ pull_request3641 |
2017-09-18 16:35:40 | pitrou | set | messages:
+ msg302474 |
2017-09-12 18:31:14 | r.david.murray | set | messages:
+ msg301988 |
2017-09-12 18:28:57 | r.david.murray | set | nosy:
+ r.david.murray messages:
+ msg301987
|
2017-09-12 17:20:52 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages:
+ msg301980
|
2017-09-12 16:23:32 | christian.heimes | set | nosy:
+ christian.heimes messages:
+ msg301973
|
2017-09-12 16:12:39 | vstinner | set | messages:
+ msg301971 |
2017-09-12 16:01:25 | vstinner | set | messages:
+ msg301968 |
2017-09-12 15:46:06 | Arfrever | set | status: closed -> open resolution: fixed -> (no value) messages:
+ msg301964
|
2017-09-10 18:19:37 | pitrou | set | pull_requests:
+ pull_request3472 |
2017-09-10 09:04:50 | Arfrever | set | nosy:
+ Arfrever messages:
+ msg301805
|
2017-09-07 16:58:45 | vstinner | set | status: open -> closed resolution: fixed messages:
+ msg301596
stage: patch review -> resolved |
2017-09-07 16:56:26 | vstinner | set | messages:
+ msg301595 |
2017-09-07 00:50:54 | gregory.p.smith | set | messages:
+ msg301559 |
2017-09-06 23:23:08 | vstinner | set | messages:
+ msg301543 |
2017-09-06 22:58:47 | vstinner | set | messages:
+ msg301539 |
2017-09-06 21:15:49 | pitrou | set | stage: needs patch -> patch review |
2017-09-06 21:15:38 | pitrou | set | messages:
+ msg301521 |
2017-09-06 21:12:43 | pitrou | set | messages:
+ msg301520 |
2017-09-06 21:11:07 | pitrou | set | pull_requests:
+ pull_request3398 |
2017-09-06 21:10:49 | pitrou | create | |