classification
Title: IDLE: Finish regrouping ConfigDialog methods
Type: enhancement Stage: resolved
Components: IDLE Versions: Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: terry.reedy
Priority: normal Keywords:

Created on 2017-07-27 18:37 by terry.reedy, last changed 2017-07-28 00:51 by terry.reedy. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2908 merged terry.reedy, 2017-07-27 18:39
PR 2925 merged terry.reedy, 2017-07-27 22:31
Messages (4)
msg299335 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-27 18:37
Finish rearranging the methods of configdialog.ConfigDialog to group together methods pertaining to each tab and the button block.  Doing so has and will help in writing tests.  It is also preparation for splitting ConfigDialog, which currently has more than 70 methods, into multiple more maintainable classes.

#30993, pr2831 moved the methods pertaining to the font tab right after create_font_tab.  #31003, pr2859 did the same for methods pertaining to the general tab.  In both case, the generated diff had a + block at the new location and - block at the old locations.

When I did the same for the highlight tab for #31001, the number of methods and lines moved was perhaps doubled, which meant that more of the other lines changed position.  The result was a huge diff, by default unrendered, that deleted and inserted most of the lines in the file.  Adding real edits on top of this would result in a worse huge diff.

So I decided instead to open this issue and finish method movement (for the dialog, button group, and keys group) to the extent I can now.  (The order within groups may be adjusted later as tests are written and knowledge about the methods is gained.)
msg299348 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-27 20:21
After finishing the patch, I expect that the highlight and keys groups will need some changes.
msg299352 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-27 22:28
New changeset b1660800f4f519dbfab9e5a4ad3eae1cfabab3ed by Terry Jan Reedy in branch 'master':
bpo-31060: IDLE: Finish regrouping ConfigDialog methods (#2908)
https://github.com/python/cpython/commit/b1660800f4f519dbfab9e5a4ad3eae1cfabab3ed
msg299358 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2017-07-28 00:50
New changeset 2cbb6733bfe54e87622a6372f83b73bddf3c4078 by Terry Jan Reedy in branch '3.6':
[3.6] bpo-31060: IDLE: Finish regrouping ConfigDialog methods (GH-2908) (#2925)
https://github.com/python/cpython/commit/2cbb6733bfe54e87622a6372f83b73bddf3c4078
History
Date User Action Args
2017-07-28 00:51:27terry.reedysetstatus: open -> closed
resolution: fixed
stage: needs patch -> resolved
2017-07-28 00:50:41terry.reedysetmessages: + msg299358
2017-07-27 22:31:27terry.reedysetpull_requests: + pull_request2976
2017-07-27 22:28:05terry.reedysetmessages: + msg299352
2017-07-27 20:21:28terry.reedysetmessages: + msg299348
title: IDLE: Finish rearranging ConfigDialog methods -> IDLE: Finish regrouping ConfigDialog methods
2017-07-27 18:39:21terry.reedysetpull_requests: + pull_request2974
2017-07-27 18:37:03terry.reedycreate