classification
Title: Reject environment variable names containing '='
Type: behavior Stage: resolved
Components: Extension Modules Versions: Python 3.7, Python 3.6, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: larry, loewis, serhiy.storchaka
Priority: normal Keywords:

Created on 2017-06-24 19:05 by serhiy.storchaka, last changed 2017-06-25 06:51 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2382 merged serhiy.storchaka, 2017-06-24 19:08
PR 2391 merged serhiy.storchaka, 2017-06-25 04:51
PR 2392 merged serhiy.storchaka, 2017-06-25 04:54
PR 2393 merged serhiy.storchaka, 2017-06-25 05:50
PR 2394 merged serhiy.storchaka, 2017-06-25 05:53
Messages (6)
msg296781 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-24 19:05
Environment variable names shouldn't contain the '=' character, because it often is used as a separator between a name and a value. There is an exception -- starting '=' on Windows is used for defining "hidden" environment variables.

Using names containing '=' in environment dict in subprocess is prohibited in issue30730. Proposed PR prohibits names containing '=' in two other cases: in os.putenv() and os.spawn*(). It fixes the part of issue4926.
msg296802 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-25 04:33
New changeset 77703942c5997dff00c48f10df1b29b11645624c by Serhiy Storchaka in branch 'master':
bpo-30746: Prohibited the '=' character in environment variable names (#2382)
https://github.com/python/cpython/commit/77703942c5997dff00c48f10df1b29b11645624c
msg296811 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-25 06:48
New changeset af5392f5c6f8014659e995840df6ee7b5017f743 by Serhiy Storchaka in branch 'master':
bpo-30746: Port more tests for os.spawnvpe() and os.execve() from 2.7. (#2394)
https://github.com/python/cpython/commit/af5392f5c6f8014659e995840df6ee7b5017f743
msg296812 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-25 06:49
New changeset 9c2dc0c58a878ac3d1c44dd0048f8e1cfab2790e by Serhiy Storchaka in branch '3.6':
[3.6] bpo-30746: Prohibited the '=' character in environment variable names (GH-2382) (#2391)
https://github.com/python/cpython/commit/9c2dc0c58a878ac3d1c44dd0048f8e1cfab2790e
msg296813 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-25 06:49
New changeset 99e9eb6111ef6a11bfff358866c9f2b0c201ac08 by Serhiy Storchaka in branch '3.5':
[3.5] bpo-30746: Prohibited the '=' character in environment variable names (GH-2382) (#2392)
https://github.com/python/cpython/commit/99e9eb6111ef6a11bfff358866c9f2b0c201ac08
msg296814 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-25 06:50
New changeset 787826c9316b03ac8a197078ec1cdf98fa840c5c by Serhiy Storchaka in branch '2.7':
[2.7] bpo-30746: Prohibited the '=' character in environment variable names (GH-2382) (#2393)
https://github.com/python/cpython/commit/787826c9316b03ac8a197078ec1cdf98fa840c5c
History
Date User Action Args
2017-06-25 06:51:00serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-06-25 06:50:02serhiy.storchakasetmessages: + msg296814
2017-06-25 06:49:43serhiy.storchakasetmessages: + msg296813
2017-06-25 06:49:17serhiy.storchakasetmessages: + msg296812
2017-06-25 06:48:56serhiy.storchakasetmessages: + msg296811
2017-06-25 05:53:46serhiy.storchakasetpull_requests: + pull_request2441
2017-06-25 05:50:57serhiy.storchakasetpull_requests: + pull_request2440
2017-06-25 04:54:20serhiy.storchakasetpull_requests: + pull_request2439
2017-06-25 04:51:50serhiy.storchakasetpull_requests: + pull_request2438
2017-06-25 04:33:03serhiy.storchakasetmessages: + msg296802
2017-06-24 19:08:53serhiy.storchakasetpull_requests: + pull_request2431
2017-06-24 19:05:15serhiy.storchakacreate