classification
Title: Warnings in Modules/_winapi.c
Type: compile error Stage: resolved
Components: Windows Versions: Python 3.7, Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: Segev Finer, ned.deily, paul.moore, serhiy.storchaka, steve.dower, tim.golden, zach.ware
Priority: normal Keywords:

Created on 2017-06-24 10:13 by Segev Finer, last changed 2017-07-08 04:51 by ned.deily. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 2376 merged serhiy.storchaka, 2017-06-24 11:02
PR 2378 merged serhiy.storchaka, 2017-06-24 13:17
PR 2379 merged serhiy.storchaka, 2017-06-24 13:18
Messages (7)
msg296761 - (view) Author: Segev Finer (Segev Finer) * Date: 2017-06-24 10:13
..\Modules\_winapi.c(886): warning C4090: 'function': different 'const' qualifiers
..\Modules\_winapi.c(848): warning C4101: 'wenvironment_size': unreferenced local variable

Added in d174d24a5d37d1516b885dc7c82f71ecd5930700
msg296763 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-24 11:03
Thank you for noticing this Segev. I hope the following PR fixes warnings.
msg296764 - (view) Author: Segev Finer (Segev Finer) * Date: 2017-06-24 11:09
I tried the PR locally and I didn't get the warnings. :)
msg296766 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-24 13:14
New changeset 0ee32c148119031e19c79359f5c4789ee69fa355 by Serhiy Storchaka in branch 'master':
bpo-30745: Fix compiler warnings introduced in bpo-30730. (#2376)
https://github.com/python/cpython/commit/0ee32c148119031e19c79359f5c4789ee69fa355
msg296768 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-24 13:28
New changeset 0e1f9e8d3ea82262cbb9a403b70a884da5e6a6ac by Serhiy Storchaka in branch '3.6':
[3.6] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (#2378)
https://github.com/python/cpython/commit/0e1f9e8d3ea82262cbb9a403b70a884da5e6a6ac
msg296771 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-24 13:42
New changeset e0d446e9caa38923e43818f78c94f95fe0aa995e by Serhiy Storchaka in branch '3.5':
[3.5] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (#2379)
https://github.com/python/cpython/commit/e0d446e9caa38923e43818f78c94f95fe0aa995e
msg297930 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2017-07-08 04:51
New changeset d1d65015fca44b8d1f0b1df78694310270f03a6d by Ned Deily (Serhiy Storchaka) in branch '3.6':
[3.6] bpo-30745: Fix compiler warnings introduced in bpo-30730. (GH-2376) (#2378)
https://github.com/python/cpython/commit/d1d65015fca44b8d1f0b1df78694310270f03a6d
History
Date User Action Args
2017-07-08 04:51:39ned.deilysetnosy: + ned.deily
messages: + msg297930
2017-06-24 13:42:46serhiy.storchakasetmessages: + msg296771
2017-06-24 13:28:29serhiy.storchakasetmessages: + msg296768
2017-06-24 13:26:58serhiy.storchakasetstatus: open -> closed
stage: resolved
resolution: fixed
versions: + Python 3.5, Python 3.6
2017-06-24 13:18:53serhiy.storchakasetpull_requests: + pull_request2428
2017-06-24 13:17:03serhiy.storchakasetpull_requests: + pull_request2426
2017-06-24 13:14:10serhiy.storchakasetmessages: + msg296766
2017-06-24 11:09:08Segev Finersetmessages: + msg296764
2017-06-24 11:03:42serhiy.storchakasetassignee: serhiy.storchaka
messages: + msg296763
2017-06-24 11:02:02serhiy.storchakasetpull_requests: + pull_request2423
2017-06-24 10:13:59Segev Finercreate