classification
Title: Warnings in VS2015 Update 3 32-Bit
Type: behavior Stage: resolved
Components: Build, Windows Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords:

Created on 2017-06-11 22:14 by Segev Finer, last changed 2017-06-16 03:16 by zach.ware. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1963 merged Segev Finer, 2017-06-11 22:14
Messages (3)
msg295732 - (view) Author: Segev Finer (Segev Finer) * Date: 2017-06-11 22:14
I'm hitting the following warnings when building in VS2015 Update 3 in 32-bit:

liblzma:
    warning C4028: formal parameter {} different from declaration
    warning C4113: 'FARPROC' differs in parameter lists from '{}'
    warning C4244: 'initializing': conversion from '{}' to '{}', possible loss of data
    warning C4267: '=': conversion from '{}' to '{}', possible loss of data
    warning C4996: 'GetVersion': was declared deprecated

libeay:
    warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings

socketmodule:
     warning C4996: '{}': Use {}() or {}() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings (multiple)

tix:
    warning C4090: 'function': different 'const' qualifiers
    warning C4028: formal parameter {} different from declaration

And ValidateUcrtbase in python.vcxproj is failing on first build because it depends on ctypes but runs before it's built when building using the pcbuild.sln
msg296151 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-06-16 03:12
New changeset c9318853bbe8d62cb72ed853b0ffb75311ea474c by Zachary Ware (Segev Finer) in branch 'master':
bpo-30631: Silence MSVC warnings in third-party code (GH-1963)
https://github.com/python/cpython/commit/c9318853bbe8d62cb72ed853b0ffb75311ea474c
msg296152 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-06-16 03:16
Thanks for the patch!
History
Date User Action Args
2017-06-16 03:16:08zach.waresetstatus: open -> closed
messages: + msg296152

components: + Build
resolution: fixed
stage: resolved
2017-06-16 03:12:07zach.waresetmessages: + msg296151
2017-06-11 22:14:42Segev Finersetpull_requests: + pull_request2170
2017-06-11 22:14:26Segev Finercreate