classification
Title: Warn about tuple parameters
Type: behavior Stage:
Components: Interpreter Core Versions: Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: georg.brandl Nosy List: benjamin.peterson, georg.brandl
Priority: normal Keywords: patch

Created on 2008-06-08 01:45 by benjamin.peterson, last changed 2008-06-08 23:11 by benjamin.peterson. This issue is now closed.

Files
File name Uploaded Description Edit
tuple_parameters_warn.patch benjamin.peterson, 2008-06-08 01:45
tuple_parameters_warn2.patch benjamin.peterson, 2008-06-08 17:19
Messages (6)
msg67820 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-06-08 01:45
This patch adds Py3k warnings to nested tuple parameters.
msg67823 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-06-08 08:16
Why not warn in the AST, like for the other syntax-related changes?
The relevant location is ast_for_arguments, line 680 in current SVN.
msg67825 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-06-08 08:23
Also a test is missing.
msg67842 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-06-08 17:19
> Why not warn in the AST, like for the other syntax-related changes?

because I was reading through symtable.c at the time. :)

Anyway, here's a better patch.
msg67845 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-06-08 18:04
Replace "upacking" with "unpacking" and you can commit it :)
msg67850 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-06-08 23:11
Done with r64045.
History
Date User Action Args
2008-06-08 23:11:06benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg67850
2008-06-08 18:04:17georg.brandlsetmessages: + msg67845
2008-06-08 17:19:40benjamin.petersonsetfiles: + tuple_parameters_warn2.patch
messages: + msg67842
2008-06-08 08:23:33georg.brandlsetmessages: + msg67825
2008-06-08 08:17:07georg.brandlsetmessages: + msg67823
2008-06-08 01:45:53benjamin.petersoncreate