classification
Title: textwrap: placeholder backtracking special case lacks test coverage
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: jonathaneunice, serhiy.storchaka
Priority: normal Keywords:

Created on 2017-06-07 16:40 by jonathaneunice, last changed 2017-06-10 04:17 by jonathaneunice. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1988 merged jonathaneunice, 2017-06-07 19:52
PR 2064 merged jonathaneunice, 2017-06-10 04:17
Messages (2)
msg295354 - (view) Author: Jonathan Eunice (jonathaneunice) * Date: 2017-06-07 16:40
A rare case in textwrap when max_lines insufficient and textwrap needs to backtrack to a previous line to add the placeholder seems to lack test coverage.

This issue added as prereq for suggesting an additional test. PR imminent.

Code: Lib/textwrap.py (as is)
Test: Lib/test/test_textwrap.py (extended)
msg295368 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-06-07 20:49
New changeset 5edf827c8052958b9d293f75ce8d93b66c1d58da by Serhiy Storchaka (Jonathan Eunice) in branch 'master':
bpo-30591: Added test for textwrap backtracking. (#1988)
https://github.com/python/cpython/commit/5edf827c8052958b9d293f75ce8d93b66c1d58da
History
Date User Action Args
2017-06-10 04:17:35jonathaneunicesetpull_requests: + pull_request2127
2017-06-07 20:51:14serhiy.storchakasetstatus: open -> closed
stage: resolved
resolution: fixed
versions: + Python 3.7, - Python 3.6
2017-06-07 20:49:15serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg295368
2017-06-07 19:52:10jonathaneunicesetpull_requests: + pull_request2054
2017-06-07 16:40:44jonathaneunicecreate