classification
Title: [2.7] sysconfig.is_python_build() doesn't work if Python is built with VS 2008
Type: Stage: resolved
Components: Build, Library (Lib), Windows Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Priority: normal Keywords:

Created on 2017-05-11 10:01 by vstinner, last changed 2017-05-12 11:33 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1544 merged vstinner, 2017-05-11 10:03
Messages (4)
msg293485 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-05-11 10:01
When Python 2.7 is compiled by VS 2008 using PC/VS9.0/ solution, the executable is PC/VS9.0/{amd64,x86}/python(_d).exe. sysconfig.is_python_build() handles PC/VS7.1/ and PCbuild/ builds, but not PC/VS9.0/ builds.

Attached PR fixes is_python_build() for VS 2008.
msg293486 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-05-11 10:03
See also bpo-30313: Tests of Python 2.7 VS9.0 buildbots must be run with -uall -rwW options.

The PR also contains a fix for test_regrtest, see: http://bugs.python.org/issue30283#msg293476
msg293535 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-05-12 09:31
New changeset f2e894cfd9b6f5d6aacc276476262d481203030c by Victor Stinner in branch '2.7':
bpo-30342: Fix sysconfig.is_python_build() on VS9.0 (#1544)
https://github.com/python/cpython/commit/f2e894cfd9b6f5d6aacc276476262d481203030c
msg293545 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-05-12 11:33
I tested manually my change: it fixes the issue ;-)
History
Date User Action Args
2017-05-12 11:33:40vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg293545

stage: resolved
2017-05-12 09:31:10vstinnersetmessages: + msg293535
2017-05-11 10:03:20vstinnersetpull_requests: + pull_request1643
2017-05-11 10:03:00vstinnersetmessages: + msg293486
2017-05-11 10:01:02vstinnercreate