classification
Title: Add an explaining comment in _PyTrash_thread_destroy_chain()
Type: enhancement Stage: resolved
Components: Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: pitrou Nosy List: pitrou, xiang.zhang
Priority: normal Keywords:

Created on 2017-05-11 10:00 by xiang.zhang, last changed 2017-05-13 05:37 by xiang.zhang. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1545 merged xiang.zhang, 2017-05-11 10:03
Messages (2)
msg293484 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2017-05-11 10:00
Studying how trashcan works I get puzzled about why increasing trash_delete_nesting in _PyTrash_thread_destroy_chain.  I asked Antoine privately (thought he was the author).  Antoine told me the reason and suggested add a comment here to help understand.
msg293595 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2017-05-13 05:36
New changeset a66f9c6bb134561a24374f10e8c35417d356ce14 by Xiang Zhang in branch 'master':
bpo-30341: Improve _PyTrash_thread_destroy_chain() a little bit (#1545)
https://github.com/python/cpython/commit/a66f9c6bb134561a24374f10e8c35417d356ce14
History
Date User Action Args
2017-05-13 05:37:37xiang.zhangsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-05-13 05:36:16xiang.zhangsetmessages: + msg293595
2017-05-11 10:03:58xiang.zhangsetpull_requests: + pull_request1644
2017-05-11 10:00:26xiang.zhangcreate