This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Pull Requests need more detail
Type: enhancement Stage: resolved
Components: Versions:
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: Jensen Taylor, brett.cannon, vstinner
Priority: low Keywords:

Created on 2017-05-10 18:02 by Jensen Taylor, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 1539 closed python-dev, 2017-05-10 18:03
Messages (4)
msg293447 - (view) Author: Jensen Taylor (Jensen Taylor) * Date: 2017-05-10 18:02
Made a PR for this
msg293449 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2017-05-10 19:19
I'm not sure if this is going to be useful enough to force all contributors to deal with. Justification for a change should be on and that's mentioned in the guidelines. As for testing, the Travis/AppVeyor failures should communicate that. And for specifying the issue number, there's a status check for that to help communicate it.

I'll let other core devs comment, but while I appreciate what Jensen is trying to help with, I don't think the template helps enough to justify forcing every contributor to have to deal with it.

You can also bring this up on the core-workflow mailing list, Jensen, if you want to discuss it there.
msg293459 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-05-10 23:07
> What is this pull request for?

I didn't notice so many PR without useful commit message (PR description). Not sure that it's useful.

> Include version updates if necessary.

I don't understand this part.

> Make sure you have signed the CLA agreement before continuing

We have a bot for that and the bot explains how to sign it, no?

> ### Reason to modify

I never saw such template in any other project. I'm not sure that we must require an exact format for new PR.

> ### Tests and reviews
> I have tested the code and it works.

While I run Linux and have Windows and FreeBSD VM, sometimes I'm lazy and rely on the CI. I consider that it's waste to burn CI CPUs sometimes :-) For example, it's not that easy to test a change specific to Windows on Python 2.7, but AppVeyor now runs tests for you!


@Jensen: I feel that you have useful hints for new contributors, but I suggest you to enhance the devguide instead of using a template.
msg293513 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2017-05-11 17:51
OK, since Victor has verified my thinking wasn't totally off-target, I'm going to close this.

Thanks for the idea and taking the time for the PR, Jensen. If you do want to file issues or PRs against the devguide, the repo is at
Date User Action Args
2022-04-11 14:58:46adminsetgithub: 74521
2017-05-11 17:51:13brett.cannonsetstatus: open -> closed
resolution: rejected
messages: + msg293513

stage: resolved
2017-05-10 23:07:16vstinnersetnosy: + vstinner
messages: + msg293459
2017-05-10 19:19:38brett.cannonsetpriority: normal -> low
nosy: + brett.cannon
messages: + msg293449

2017-05-10 18:03:24python-devsetpull_requests: + pull_request1638
2017-05-10 18:02:47Jensen Taylorcreate