➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-05-05 07:39 by masamoto, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 1473 | merged | masamoto, 2017-05-05 07:47 | |
| Messages (4) | |||
|---|---|---|---|
| msg293057 - (view) | Author: Masayuki Yamamoto (masamoto) * | Date: 2017-05-05 07:39 | |
Python/thread_foobar.h is the template code that is threading adaptation for new platforms, and it hasn't been used on actual platforms. As a matter of fact, Python/thread_pthread.h and Python/thread_nt.h give concrete examples of adaptation, therefore, I think thread_foobar.h hasn't needed no more. In addition, there was an issue that only changed thread_foobar.h to fix overlooking (issue21312). python-dev: https://mail.python.org/pipermail/python-dev/2017-May/147840.html |
|||
| msg293065 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2017-05-05 07:52 | |
Copy of my answer on the python-dev thread: You can remove thread_foobar.h. I don't think that anyone still wants to use this template. The other thread_*.h files can be used as template as well. Victor |
|||
| msg293067 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-05-05 08:04 | |
New changeset fdaeea620f8c78da89cddba4ab010c64535800e0 by Victor Stinner (Masayuki Yamamoto) in branch 'master': bpo-30279: Remove unused Python/thread_foobar.h (#1473) https://github.com/python/cpython/commit/fdaeea620f8c78da89cddba4ab010c64535800e0 |
|||
| msg293070 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-05-05 08:09 | |
I hope that your merged change will now make your work simpler ;-) I don't want to backport this change, so I close the issue. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:46 | admin | set | github: 74465 |
| 2017-05-05 08:09:04 | vstinner | set | status: open -> closed resolution: fixed messages: + msg293070 stage: resolved |
| 2017-05-05 08:04:15 | vstinner | set | messages: + msg293067 |
| 2017-05-05 07:52:38 | vstinner | set | nosy:
+ vstinner messages: + msg293065 |
| 2017-05-05 07:47:53 | masamoto | set | pull_requests: + pull_request1572 |
| 2017-05-05 07:39:25 | masamoto | create | |