classification
Title: Rename 'name' to 'fullname' argument to ExtensionFileLoader
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.11
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: docs@python Nosy List: brett.cannon, docs@python, iritkatriel, sayanchowdhury, zkneupper
Priority: normal Keywords: easy, patch

Created on 2017-05-04 22:24 by brett.cannon, last changed 2021-05-17 18:48 by zkneupper.

Pull Requests
URL Status Linked Edit
PR 1735 open sayanchowdhury, 2017-05-22 23:31
PR 26195 open zkneupper, 2021-05-17 18:48
Messages (5)
msg293022 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2017-05-04 22:24
https://docs.python.org/3/library/importlib.html#importlib.machinery.ExtensionFileLoader says "fullname, path" for __init__(), but https://github.com/python/cpython/blob/647c3d381e67490e82cdbbe6c96e46d5e1628ce2/Lib/importlib/_bootstrap_external.py#L909 says "name, path". While I would much rather change the parameter name to match the rest of the module, I don't think I'm comfortable with the backwards-compatibility breakage over just a single parameter name (although chances are no one will notice in either direction as everyone probably passes by position).
msg293122 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2017-05-05 16:34
Another option is to rename 'name' to 'fullname', make 'name' keyword-only, and then raise a DeprecationWarning if 'name' is used, eventually removing the keyword-only argument.
msg294193 - (view) Author: Sayan Chowdhury (sayanchowdhury) * Date: 2017-05-22 21:53
I am starting to work on this issue.
msg339886 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2019-04-10 19:37
I realized another solution to this is to make the argument positional-only, then the name simply doesn't matter. Probably unnecessary breakage, though.
msg393702 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-05-14 23:14
The PR was reviewed but it now has merge conflicts and possibly a test failure on MacOS.
History
Date User Action Args
2021-05-17 18:48:05zkneuppersetkeywords: + patch
nosy: + zkneupper
pull_requests: + pull_request24812
2021-05-14 23:14:57iritkatrielsettitle: Make importlib.abc.ExtensionFileLoader.__init__() documentation match code -> Rename 'name' to 'fullname' argument to ExtensionFileLoader
components: + Library (Lib), - Documentation

keywords: + easy
nosy: + iritkatriel
versions: + Python 3.11, - Python 3.7, Python 3.8
messages: + msg393702
2019-04-10 19:37:48brett.cannonsetmessages: + msg339886
versions: + Python 3.8
2017-07-23 23:56:36berker.peksagsetstage: needs patch -> patch review
type: enhancement
versions: + Python 3.7
2017-05-22 23:31:00sayanchowdhurysetpull_requests: + pull_request1826
2017-05-22 21:53:26sayanchowdhurysetnosy: + sayanchowdhury
messages: + msg294193
2017-05-05 16:34:30brett.cannonsetmessages: + msg293122
2017-05-04 22:24:49brett.cannoncreate