classification
Title: Fix for issue 8743 not available in python MacOS 3.5.1
Type: Stage: resolved
Components: Library (Lib), macOS Versions: Python 3.5
process
Status: closed Resolution: works for me
Dependencies: Superseder:
Assigned To: Nosy List: Horacio Hoyos, ned.deily, r.david.murray, ronaldoussoren, serhiy.storchaka
Priority: normal Keywords:

Created on 2017-04-22 18:54 by Horacio Hoyos, last changed 2017-04-22 19:50 by ned.deily. This issue is now closed.

Messages (5)
msg292134 - (view) Author: Horacio Hoyos (Horacio Hoyos) Date: 2017-04-22 18:54
Hi all,

I was having issues while testing a custom Set implementation using the _collections_abc base MutableSet and found that my issue was apparently resolved with issue 8743. My test is simple:

ms = MySetImpl()
ms & 'testword'

which should fail with TypeError, given that in the 8743 fix the __and__ incorporated a test for isinstance(other, Set).

Looking at the _collections_abc.py in my installation (/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/_collections_abc.py) I can not see the changes in the patches submitted for issue 8743.
msg292135 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2017-04-22 19:16
Then you have a broken copy of 3.5.1.  There is nothing OS-specific about that file.
msg292136 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2017-04-22 19:23
>> Then you have a broken copy of 3.5.1.

Yes. You don't say from where you installed Python 3.5.1 but I just took a quick look at _collections_abc.py in both the versions installed by the python.org 3.5.1 macOS installer and by the current 3.5.3 version (which you should update to, or, better, 3.6.1) and the Issue8743 changes appear to be there.  If you still believe there is a problem with Python here, please reopen and provide a complete test case.
msg292137 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-04-22 19:30
But there is no neither an entry #8743, nor neighbour entries #14710 and #13355 in Misc/NEWS. Seems Misc/NEWS is broken.
msg292138 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2017-04-22 19:50
> But there is no neither an entry #8743, nor neighbour entries #14710 and #13355 in Misc/NEWS. Seems Misc/NEWS is broken.

Hmm. They seem to have been properly preserved in the current 3.6 and master branch versions of Misc/HISTORY.  Perhaps the 3.5 Misc/NEWS was corrupted in a merge along the way?  In any case, this is not relevant to the OP's problem.  Once the auto-generation of Misc/NEWS is implemented, we're going to have to go back and redo Misc/NEWS and Misc/HISTORY in active branches.  I don't think there is a need for a separate issue to track that but, if you want to open one, Serhiy, feel free to do so.
History
Date User Action Args
2017-04-22 19:50:56ned.deilysetmessages: + msg292138
2017-04-22 19:31:34serhiy.storchakasetstatus: open -> closed
resolution: works for me
stage: resolved
2017-04-22 19:30:51serhiy.storchakasetstatus: closed -> open

nosy: + serhiy.storchaka
messages: + msg292137

resolution: works for me -> (no value)
stage: resolved -> (no value)
2017-04-22 19:23:13ned.deilysetstatus: open -> closed
resolution: works for me
messages: + msg292136

stage: resolved
2017-04-22 19:16:25r.david.murraysetnosy: + r.david.murray
messages: + msg292135
2017-04-22 18:54:20Horacio Hoyoscreate