classification
Title: Use add_mutually_exclusive_group(required=True) in zipfile and tarfile CLI
Type: enhancement Stage: resolved
Components: Demos and Tools Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: SilentGhost, serhiy.storchaka
Priority: normal Keywords:

Created on 2017-04-01 06:38 by serhiy.storchaka, last changed 2017-04-07 15:56 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 944 merged serhiy.storchaka, 2017-04-01 06:40
Messages (2)
msg290966 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-04-01 06:38
In the comment to the patch on issue28115 SilentGhost suggested to pass required=True to add_mutually_exclusive_group(). This makes the last "else" not needed.

Proposed patch implements this idea for zipfile and tarfile. It also improves error handling when pass empty tar archive name, and adds a hyphen in "command-line".
msg291276 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-04-07 15:56
New changeset 150cd1916a59e750ce88c65325de9ef0c42c6cb5 by Serhiy Storchaka in branch 'master':
bpo-29958: Minor improvements to zipfile and tarfile CLI. (#944)
https://github.com/python/cpython/commit/150cd1916a59e750ce88c65325de9ef0c42c6cb5
History
Date User Action Args
2017-04-07 15:56:35serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2017-04-07 15:56:14serhiy.storchakasetmessages: + msg291276
2017-04-01 06:40:36serhiy.storchakasetpull_requests: + pull_request1126
2017-04-01 06:38:51serhiy.storchakacreate