➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-03-28 13:18 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 2262 | merged | kojoidrissa, 2017-06-18 02:17 | |
| PR 2532 | merged | kojoidrissa, 2017-07-02 02:41 | |
| PR 2533 | merged | kojoidrissa, 2017-07-02 02:41 | |
| Messages (8) | |||
|---|---|---|---|
| msg290712 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2017-03-28 13:18 | |
The asyncio set_write_buffer_limits() documentation doesn't specify unit of high and low parameters. Moreover, it would to explain better the effect of high and low: * pause_writing() is called when the buffer size becomes larger or equal to high * (if writing is pause) resume_writing() is called when the buffer size becomes smaller or equal to low |
|||
| msg290713 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-03-28 13:19 | |
See also https://github.com/asyncio-doc/asyncio-doc/issues/17 for a more general documentation request on asyncio parameters (on the external asyncio doc). |
|||
| msg290716 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-03-28 13:55 | |
It would also be nice to: * link to set_write_buffer_limits() from drain() * link to set_write_buffer_limits() from pause_writing() / resume_writing() * mention asyncio default values for set_write_buffer_limits(): low=16 kB, high=64 kB (kb? kib? i never know :-/) |
|||
| msg296480 - (view) | Author: Mariatta (Mariatta) * |
Date: 2017-06-20 19:32 | |
New changeset 5200a7c7f9ea65a96330c5f276f4acc6ec70854e by Mariatta (Kojo Idrissa) in branch 'master': bpo-29933: Improve set_write_buffer_limits description (GH-2262) https://github.com/python/cpython/commit/5200a7c7f9ea65a96330c5f276f4acc6ec70854e |
|||
| msg297090 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-06-28 00:55 | |
Oh, thanks for the documentation! Now the change should just be backported to other branches. |
|||
| msg297501 - (view) | Author: Mariatta (Mariatta) * |
Date: 2017-07-02 02:47 | |
New changeset 4685e56596f9f332e402c79c913a73b19f4411e1 by Mariatta (Kojo Idrissa) in branch '3.5': [3.5] bpo-29933: Improve set_write_buffer_limits description (GH-2262) (GH-2533) https://github.com/python/cpython/commit/4685e56596f9f332e402c79c913a73b19f4411e1 |
|||
| msg297502 - (view) | Author: Mariatta (Mariatta) * |
Date: 2017-07-02 02:48 | |
New changeset 03af4282423b1c287a194664f90496cfc9cf20c7 by Mariatta (Kojo Idrissa) in branch '3.6': [3.6] bpo-29933: Improve set_write_buffer_limits description (GH-2262) (GH-2532) https://github.com/python/cpython/commit/03af4282423b1c287a194664f90496cfc9cf20c7 |
|||
| msg305014 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2017-10-25 23:00 | |
PR 2262 has been merged and backported to bugfix branches so I think this issue can be closed now. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:44 | admin | set | github: 74119 |
| 2017-10-25 23:00:11 | berker.peksag | set | status: open -> closed type: enhancement nosy: + berker.peksag messages: + msg305014 resolution: fixed stage: needs patch -> resolved |
| 2017-07-02 02:48:10 | Mariatta | set | messages: + msg297502 |
| 2017-07-02 02:47:58 | Mariatta | set | messages: + msg297501 |
| 2017-07-02 02:41:20 | kojoidrissa | set | pull_requests: + pull_request2600 |
| 2017-07-02 02:41:13 | kojoidrissa | set | pull_requests: + pull_request2599 |
| 2017-06-28 00:55:48 | vstinner | set | messages: + msg297090 |
| 2017-06-20 19:32:04 | Mariatta | set | messages: + msg296480 |
| 2017-06-18 03:39:44 | Mariatta | set | versions: + Python 3.5, Python 3.6 |
| 2017-06-18 02:17:43 | kojoidrissa | set | pull_requests: + pull_request2312 |
| 2017-04-12 01:34:47 | Mariatta | set | stage: needs patch |
| 2017-04-12 01:34:38 | Mariatta | set | assignee: docs@python -> Mariatta nosy: + Mariatta |
| 2017-03-28 13:55:57 | vstinner | set | messages: + msg290716 |
| 2017-03-28 13:19:24 | vstinner | set | messages: + msg290713 |
| 2017-03-28 13:18:59 | vstinner | create | |