classification
Title: Error “importlib.h, importlib_external.h updated. You will need to rebuild pythoncore to see the changes.” is reported when build Python on Winodws
Type: compile error Stage: resolved
Components: Build Versions: Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Karen, zach.ware
Priority: normal Keywords:

Created on 2017-02-23 10:01 by Karen, last changed 2017-09-08 21:38 by zach.ware. This issue is now closed.

Files
File name Uploaded Description Edit
Python3_x86_build.log Karen, 2017-02-23 10:01
Messages (2)
msg288436 - (view) Author: Karen (Karen) Date: 2017-02-23 10:01
We use VS2015 to build Python(branch 3.6)on Windows. It failed with error "importlib.h, importlib_external.h updated. You will need to rebuild pythoncore to see the changes". This error is reported from Python 3.6 branch revision 3ab24bd. The detailed error log file is attached. Could you please help to take a look? Thank you so much!

Here is repro steps:
1. git clone -b "3.6" -c core.autocrlf=true https://github.com/python/cpython.git D:\Python3\src
2. checkout the revision to 3ab24bd.
3. build -e -r -v
msg301738 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2017-09-08 21:38
Hi Karen,

You may have already noticed that this has been fixed since you reported it; sorry it's taken so long for anybody to reply!  The issue was that importlib.h and importlib_external.h (generated files) were not checked in when their source files were changed, as is our convention for those files.  We have since enabled pre-merge CI to check this sort of thing.
History
Date User Action Args
2017-09-08 21:38:49zach.waresetstatus: open -> closed

nosy: + zach.ware
messages: + msg301738

resolution: fixed
stage: resolved
2017-02-23 10:01:40Karencreate