classification
Title: Simplify argument parsing in sorted() and list.sort()
Type: enhancement Stage: resolved
Components: Interpreter Core Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: josh.r, python-dev, rhettinger, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2017-01-20 06:59 by serhiy.storchaka, last changed 2017-01-21 21:06 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
sort-arg-parse.patch serhiy.storchaka, 2017-01-20 06:59 review
sort-arg-parse-2.patch serhiy.storchaka, 2017-01-20 09:03 review
Messages (4)
msg285887 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-01-20 06:59
Proposed patch simplifies argument parsing in sorted() and list.sort().

list.sort() now uses the support of keyword-only parameters in PyArg_ParseTupleAndKeywords().

Keyword arguments now are passed as is to list.sorted() in sorted().
msg285901 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-01-20 11:19
sort-arg-parse-2.patch now LGTM with the comment, thanks :-)
msg285964 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2017-01-21 21:05
New changeset 69bd5c497a82 by Serhiy Storchaka in branch 'default':
Issue #29331: Simplified argument parsing in sorted() and list.sort().
https://hg.python.org/cpython/rev/69bd5c497a82
msg285965 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-01-21 21:06
Thanks Victor.
History
Date User Action Args
2017-01-21 21:06:23serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg285965

stage: patch review -> resolved
2017-01-21 21:05:32python-devsetnosy: + python-dev
messages: + msg285964
2017-01-21 00:53:38josh.rsetnosy: + josh.r
2017-01-20 11:19:20vstinnersetmessages: + msg285901
2017-01-20 09:03:24serhiy.storchakasetfiles: + sort-arg-parse-2.patch
2017-01-20 06:59:39serhiy.storchakacreate