➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2017-01-16 09:19 by Alexey Popravka, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| json_loads_bytes.diff | ammar2, 2017-01-20 03:06 | review | ||
| Messages (8) | |||
|---|---|---|---|
| msg285545 - (view) | Author: Alexey Popravka (Alexey Popravka) | Date: 2017-01-16 09:19 | |
json.loads function was changed in Python 3.6 to accept bytes and bytearrays, however documentation is missing `versionchanged` block describing this changes. |
|||
| msg285762 - (view) | Author: Ammar Askar (ammar2) *  |
Date: 2017-01-18 21:53 | |
To anyone more experienced with python documentation, is behavior like this actually supposed to be documented? For some more historical context, the support for bytes in the json module was removed in this issue: https://bugs.python.org/issue4136 and then re-added in this one: https://bugs.python.org/issue17909 |
|||
| msg285763 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2017-01-18 22:14 | |
Yes, this should be documented with a versionchanged. The removal was for python3 so we didn't need a versionchanged there; it was just a difference from python2, and the python3 docs were "restarted" with (almost) no back references to python2. |
|||
| msg285869 - (view) | Author: Ammar Askar (ammar2) * |
Date: 2017-01-20 03:06 | |
Attached patch adds a versionchanged block to specify that bytes and bytesarray can now be used and the types of encodings it supports (as taken from the whatsnew changes here https://hg.python.org/cpython/rev/e9e1bf9ec2ac#l2.7) |
|||
| msg285878 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2017-01-20 05:40 | |
New changeset 3452ff9e8f0a by Raymond Hettinger in branch '3.6': Issue #29281: Fill-in a missing versionchanged entry https://hg.python.org/cpython/rev/3452ff9e8f0a |
|||
| msg285879 - (view) | Author: Raymond Hettinger (rhettinger) * |
Date: 2017-01-20 05:41 | |
Thanks for the patch. |
|||
| msg285892 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-01-20 08:53 | |
The wording looks little misleading. There is the encoding parameter in json.loads(). It is deprecated and ignored. |
|||
| msg285914 - (view) | Author: Ammar Askar (ammar2) * |
Date: 2017-01-20 15:59 | |
Which part is misleading, do you think the use of "encoding" could be confused with the argument encoding? There is a note right above the versionchanged block that says: `The other arguments have the same meaning as in load(), except encoding which is ignored and deprecated.` If that is the concern then I think changing the wording to be, "the encoding of the input string should be ..." |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:42 | admin | set | github: 73467 |
| 2017-01-20 15:59:08 | ammar2 | set | messages: + msg285914 |
| 2017-01-20 08:53:35 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg285892 |
| 2017-01-20 05:41:14 | rhettinger | set | status: open -> closed resolution: fixed messages: + msg285879 |
| 2017-01-20 05:40:52 | python-dev | set | nosy:
+ python-dev messages: + msg285878 |
| 2017-01-20 05:27:13 | rhettinger | set | assignee: docs@python -> rhettinger nosy: + rhettinger |
| 2017-01-20 03:06:41 | ammar2 | set | files:
+ json_loads_bytes.diff keywords: + patch messages: + msg285869 |
| 2017-01-18 22:14:02 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg285763 |
| 2017-01-18 21:53:24 | ammar2 | set | nosy:
+ ammar2 messages: + msg285762 |
| 2017-01-16 09:19:59 | Alexey Popravka | create | |