classification
Title: Broken indentation in FancyURLopener documentation
Type: behavior Stage: resolved
Components: Documentation Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: berker.peksag, docs@python, orsenthil, python-dev
Priority: normal Keywords: patch

Created on 2017-01-07 05:49 by berker.peksag, last changed 2017-01-24 06:30 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
docfix.diff berker.peksag, 2017-01-07 05:49
Messages (5)
msg284888 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2017-01-07 05:49
I noticed this while taking a look at urllib docs for issue 29182. Indentation of prompt_user_passwd() is broken and it looks like it's part of the note directive: https://docs.python.org/2/library/urllib.html#urllib.FancyURLopener.prompt_user_passwd

Python 3 version renders fine: https://docs.python.org/3/library/urllib.request.html#urllib.request.FancyURLopener.prompt_user_passwd

Here is a patch.
msg284889 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2017-01-07 05:53
The patch looks good to me, and can committed. Thanks!
msg284890 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2017-01-07 06:14
New changeset 31172ecb9e40 by Berker Peksag in branch '2.7':
Issue #29189: Fix broken indentation in FancyURLopener documentation
https://hg.python.org/cpython/rev/31172ecb9e40
msg284891 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2017-01-07 06:15
Thanks for the review, Senthil.
msg286142 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2017-01-24 06:30
New changeset fb2885f9b4dd by Martin Panter in branch '2.7':
Issue #29189: Fix indentation in RST markup
https://hg.python.org/cpython/rev/fb2885f9b4dd

New changeset 75e341d79c99 by Martin Panter in branch '3.5':
Issue #29189: Fix indentation in RST markup
https://hg.python.org/cpython/rev/75e341d79c99

New changeset f0854405c830 by Martin Panter in branch '3.6':
Issues #29189: Merge indentation fixes from 3.5
https://hg.python.org/cpython/rev/f0854405c830

New changeset d654b7c63b48 by Martin Panter in branch 'default':
Issues #29189: Merge indentation fixes from 3.6
https://hg.python.org/cpython/rev/d654b7c63b48
History
Date User Action Args
2017-01-24 06:30:04python-devsetmessages: + msg286142
2017-01-07 06:15:01berker.peksagsetstatus: open -> closed
resolution: fixed
messages: + msg284891

stage: patch review -> resolved
2017-01-07 06:14:31python-devsetnosy: + python-dev
messages: + msg284890
2017-01-07 05:53:46orsenthilsetmessages: + msg284889
2017-01-07 05:49:55berker.peksagcreate