➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Curses Module should check for is_keypad and not window flags
Type: compile error Stage: resolved
Components: Extension Modules Versions: Python 3.6
process
Status: closed Resolution: duplicate
Dependencies: Superseder: Fix curses module compilation with ncurses6
View: 25720
Assigned To: Nosy List: Roy Marples, masamoto
Priority: normal Keywords: patch

Created on 2017-01-05 21:57 by Roy Marples, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
cursesmodule.patch Roy Marples, 2017-01-05 22:15
Messages (4)
msg284771 - (view) Author: Roy Marples (Roy Marples) * Date: 2017-01-05 21:57 
checking whether WINDOW has _flags... no

The ncurses library can be built with an opaque window structure.
As such, it's not always possible to query it's flags.
Luckily there is the is_keypad function which works regardless of how ncurses was built.

If this test is changed, then it will help support NetBSD curses as well.
msg284775 - (view) Author: Roy Marples (Roy Marples) * Date: 2017-01-05 22:15 
Remove WINDOW test
Add is_keypad test
Change #define in _cursesmodule.c
msg284777 - (view) Author: Masayuki Yamamoto (masamoto) * Date: 2017-01-05 22:26 
#25720 is a similar issue that is originated by opaque type WINDOW.
msg284779 - (view) Author: Roy Marples (Roy Marples) * Date: 2017-01-05 22:36 
It is, sorry for noise.
History
Date User Action Args
2022-04-11 14:58:41adminsetgithub: 73356
2017-01-06 02:17:02berker.peksagsetsuperseder: Fix curses module compilation with ncurses6
resolution: duplicate
stage: resolved
2017-01-05 22:36:57Roy Marplessetstatus: open -> closed

messages: + msg284779
2017-01-05 22:26:44masamotosetnosy: + masamoto
messages: + msg284777
2017-01-05 22:15:42Roy Marplessetfiles: + cursesmodule.patch
keywords: + patch
messages: + msg284775
2017-01-05 21:57:30Roy Marplescreate