classification
Title: Make enum.py pep8 compliant
Type: enhancement Stage:
Components: Library (Lib) Versions: Python 3.7
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: barry, eli.bendersky, ethan.furman, python-dev, r.david.murray, realitix, rhettinger
Priority: normal Keywords: patch

Created on 2016-12-29 07:37 by realitix, last changed 2016-12-30 18:22 by ethan.furman. This issue is now closed.

Files
File name Uploaded Description Edit
enum_format.patch realitix, 2016-12-29 07:37 Patch to fix enum.py review
Messages (6)
msg284234 - (view) Author: Jean-Sebastien Bevilacqua (realitix) * Date: 2016-12-29 07:37
Hello,
This is my first patch on CPython, so please tell me if I do something wrong.

When executing flake8 on Lib/enum.py, there are lot of warning. This patch remove all these warnings.
msg284267 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2016-12-29 14:45
In general we do not accept PEP8 patches; it is code churn with insufficient benefit since many modules in the stdlib predate either PEP8 itself or the current version of PEP8.  However, enum is a new enough module that I suppose this might get accepted.  In any case, thank you for wanting to contribute!
msg284308 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2016-12-30 05:19
I really don't like how this patch is done or even the spirit of it.  To my eyes, some of the code looks worse (especially the addition of trailing backslashes and some odd line-wraps that aren't sensitive to readability or context).

I'm going to close this.   If Ethan wants to make minor tweaks to his whitespace or line-wrapping, I believe he can do a better job with his own code.

Jean-Sebastien, thank you for trying to contribute, but PEP-8ing other people's code generally isn't helpful.  I recommend that you find a tracker item that needs a patch for a substantive change and work on that.  I think you will find it more satisfying and will have a much greater chance of acceptance.
msg284317 - (view) Author: Jean-Sebastien Bevilacqua (realitix) * Date: 2016-12-30 06:23
Hello Raymond Hettinger,
Thanks for your advice and your comment.

I agree with you that pep8 compliant isn't useful. If you look at my patch, the first change is a unused import, not just a text formatting.

Maybe this first change can be useful ? (not importing unused module)
msg284319 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-30 06:57
New changeset bf6987b93358 by Raymond Hettinger in branch '3.6':
Issue #29103: Remove unused import.  Noticed by Jean-Sebastien Bevilacqua.
https://hg.python.org/cpython/rev/bf6987b93358
msg284337 - (view) Author: Ethan Furman (ethan.furman) * (Python committer) Date: 2016-12-30 18:22
Thanks Raymond and Jean-Sebastien.
History
Date User Action Args
2016-12-30 18:22:40ethan.furmansetmessages: + msg284337
2016-12-30 06:57:41python-devsetnosy: + python-dev
messages: + msg284319
2016-12-30 06:23:27realitixsetmessages: + msg284317
2016-12-30 05:19:15rhettingersetstatus: open -> closed

nosy: + rhettinger
messages: + msg284308

resolution: rejected
2016-12-29 14:45:13r.david.murraysetnosy: + r.david.murray
messages: + msg284267
2016-12-29 07:37:30realitixcreate