classification
Title: Example in Section 8.1.5 time Objects is broken
Type: Stage: resolved
Components: Documentation Versions: Python 3.7, Python 3.6, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: xiang.zhang Nosy List: docs@python, python-dev, rdhushyanth, xiang.zhang
Priority: normal Keywords: patch

Created on 2016-12-26 20:15 by rdhushyanth, last changed 2016-12-27 04:41 by xiang.zhang. This issue is now closed.

Files
File name Uploaded Description Edit
datetime.patch rdhushyanth, 2016-12-26 20:15 Patch to fix the example review
Python Contributor Agreement Form - signed.pdf rdhushyanth, 2016-12-27 04:11 CLA pdf
Messages (5)
msg284042 - (view) Author: Dhushyanth Ramasamy (rdhushyanth) * Date: 2016-12-26 20:15
The example doesn't import timedelta. This causes an error when attempting to run the example in the interactive window.
msg284056 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-12-27 04:06
LGTM.

Thanks for your work Dhushyanth! It's appreciated if you could sign the CLA: https://www.python.org/psf/contrib/contrib-form/.
msg284057 - (view) Author: Dhushyanth Ramasamy (rdhushyanth) * Date: 2016-12-27 04:11
Hi Xiang,
Signed the CLA, but looks like it may take two days to reflect.
msg284059 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-27 04:39
New changeset 878a91174e74 by Xiang Zhang in branch '2.7':
Issue #29078: Add the missing import in datetime.time doc example.
https://hg.python.org/cpython/rev/878a91174e74

New changeset 172b2ac82037 by Xiang Zhang in branch '3.5':
Issue #29078: Add the missing import in datetime.time doc example.
https://hg.python.org/cpython/rev/172b2ac82037

New changeset 83b089b7ab43 by Xiang Zhang in branch '3.6':
Issue #29078: Merge 3.5.
https://hg.python.org/cpython/rev/83b089b7ab43

New changeset f35c3b0b6eda by Xiang Zhang in branch 'default':
Issue #29078: Merge 3.6.
https://hg.python.org/cpython/rev/f35c3b0b6eda
msg284060 - (view) Author: Xiang Zhang (xiang.zhang) * (Python committer) Date: 2016-12-27 04:41
> Signed the CLA, but looks like it may take two days to reflect.

Thanks. This change is trivial so I can push it first. ;-)
History
Date User Action Args
2016-12-27 04:41:14xiang.zhangsetstatus: open -> closed
resolution: fixed
messages: + msg284060

stage: commit review -> resolved
2016-12-27 04:39:11python-devsetnosy: + python-dev
messages: + msg284059
2016-12-27 04:11:54rdhushyanthsetfiles: + Python Contributor Agreement Form - signed.pdf

messages: + msg284057
2016-12-27 04:06:45xiang.zhangsetversions: - Python 3.3, Python 3.4
nosy: + xiang.zhang

messages: + msg284056

assignee: docs@python -> xiang.zhang
stage: commit review
2016-12-26 20:15:52rdhushyanthcreate