classification
Title: What's New entry on compact dict mentions "faster" implementation
Type: Stage: resolved
Components: Documentation Versions: Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Jim Fasarakis-Hilliard, brendan-donegan, docs@python, inada.naoki, ned.deily, python-dev, serhiy.storchaka, vstinner, yselivanov
Priority: Keywords: patch

Created on 2016-12-15 13:52 by Jim Fasarakis-Hilliard, last changed 2016-12-16 07:55 by ned.deily. This issue is now closed.

Files
File name Uploaded Description Edit
whatsnew36.patch brendan-donegan, 2016-12-15 15:09 review
Messages (6)
msg283304 - (view) Author: Jim Fasarakis-Hilliard (Jim Fasarakis-Hilliard) * Date: 2016-12-15 13:52
Specifically, the entry reads:

"The dict type has been reimplemented to use a faster, more compact representation similar to the PyPy dict implementation."

Through, the text describing the new implementation doesn't mention anything on speed, it only mentions memory usage.

issue27350 and, specifically, msg275587 even report a slight regression ok key look-ups. Am I interpreting this differently? If not, is it a good idea to be stating it is faster?
msg283319 - (view) Author: Brendan Donegan (brendan-donegan) * Date: 2016-12-15 15:09
Agree. Patch provided.
msg283323 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-15 15:22
New changeset 181453f9a0c4 by Victor Stinner in branch '3.6':
Issue #28979: Fix What's New in Python 3.6, dict
https://hg.python.org/cpython/rev/181453f9a0c4
msg283325 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-12-15 15:23
@Ned: Would you be ok to cherry-pick 181453f9a0c4 in Python 3.6.0?
msg283372 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-12-16 07:44
New changeset 911cc601089d by Victor Stinner in branch '3.6':
Issue #28979: Fix What's New in Python 3.6, dict
https://hg.python.org/cpython/rev/911cc601089d
msg283385 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2016-12-16 07:55
[cherrypicked for 3.6.0rc2]
History
Date User Action Args
2016-12-16 07:55:29ned.deilysetstatus: open -> closed
priority: release blocker ->
messages: + msg283385

resolution: fixed
stage: resolved
2016-12-16 07:44:42python-devsetmessages: + msg283372
2016-12-15 15:54:42ned.deilysetpriority: normal -> release blocker
2016-12-15 15:23:46vstinnersetnosy: + ned.deily, inada.naoki, serhiy.storchaka, yselivanov
2016-12-15 15:23:26vstinnersetnosy: + vstinner
messages: + msg283325
2016-12-15 15:22:27python-devsetnosy: + python-dev
messages: + msg283323
2016-12-15 15:09:27brendan-donegansetfiles: + whatsnew36.patch

nosy: + brendan-donegan
messages: + msg283319

keywords: + patch
2016-12-15 13:52:12Jim Fasarakis-Hilliardcreate