➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-11-22 12:43 by Wheerd, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| frozenset-doc.patch | Wheerd, 2016-11-22 12:43 | review | ||
| frozenset-doc.patch | Wheerd, 2016-11-22 23:22 | Updated | review | |
| Messages (11) | |||
|---|---|---|---|
| msg281476 - (view) | Author: Manuel Krebber (Wheerd) * | Date: 2016-11-22 12:43 | |
The typing.FrozenSet is missing in the typing module documentation. I have attached a patch that adds it similar to the typing.Set which is already in the documentation. |
|||
| msg281514 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2016-11-22 20:50 | |
Thanks for the patch, Manuel. Looks like FrozenSet is in PEP 484 and has been added to typing.__all__ in https://github.com/python/typing/pull/261 (already synced with the stdlib version of typing module) The patch looks good to me. Adding Guido to nosy list for a commit review. |
|||
| msg281528 - (view) | Author: Ivan Levkivskyi (levkivskyi) * |
Date: 2016-11-22 22:51 | |
The patch looks good, I left just one small comment in Rietveld. |
|||
| msg281532 - (view) | Author: Manuel Krebber (Wheerd) * | Date: 2016-11-22 23:22 | |
I updated the patch to add reflect the covariance. |
|||
| msg281544 - (view) | Author: Ivan Levkivskyi (levkivskyi) * |
Date: 2016-11-23 08:29 | |
Thank you Manuel! LGTM. |
|||
| msg281594 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2016-11-24 00:53 | |
Ned: does the ban on non-critical commits to the 3.6 branch also apply to doc patches? |
|||
| msg281596 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2016-11-24 01:19 | |
Guido, doc fixes are welcome! |
|||
| msg281646 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-11-24 19:56 | |
New changeset 5d83b6a9b568 by Guido van Rossum in branch '3.5': Issue #28773: Add typing.FrozenSet docs. (Manuel Krebber) https://hg.python.org/cpython/rev/5d83b6a9b568 |
|||
| msg281647 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-11-24 19:57 | |
New changeset 7059e68db068 by Guido van Rossum in branch '3.6': Issue #28773: Add typing.FrozenSet docs. (Manuel Krebber) (3.5->3.6) https://hg.python.org/cpython/rev/7059e68db068 New changeset 00bfe5bd3553 by Guido van Rossum in branch 'default': Issue #28773: Add typing.FrozenSet docs. (Manuel Krebber) (3.6->3.7) https://hg.python.org/cpython/rev/00bfe5bd3553 |
|||
| msg281648 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2016-11-24 19:58 | |
Thanks! I pushed this into 3.5, then merged into 3.6 and default. Is that the right procedure still? |
|||
| msg281941 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2016-11-29 03:37 | |
> Is that the right procedure still? Yes, thanks! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:39 | admin | set | github: 72959 |
| 2016-11-29 03:37:15 | ned.deily | set | messages:
+ msg281941 stage: commit review -> resolved |
| 2016-11-24 19:58:38 | gvanrossum | set | status: open -> closed resolution: fixed messages: + msg281648 stage: patch review -> commit review |
| 2016-11-24 19:57:19 | python-dev | set | messages: + msg281647 |
| 2016-11-24 19:56:16 | python-dev | set | nosy:
+ python-dev messages: + msg281646 |
| 2016-11-24 01:19:07 | ned.deily | set | messages: + msg281596 |
| 2016-11-24 00:53:02 | gvanrossum | set | nosy:
+ ned.deily messages: + msg281594 |
| 2016-11-23 08:29:47 | levkivskyi | set | messages: + msg281544 |
| 2016-11-22 23:22:57 | Wheerd | set | files:
+ frozenset-doc.patch messages: + msg281532 |
| 2016-11-22 22:51:00 | levkivskyi | set | nosy:
+ levkivskyi messages: + msg281528 |
| 2016-11-22 20:50:57 | berker.peksag | set | nosy:
+ docs@python, berker.peksag, gvanrossum messages: + msg281514 assignee: docs@python components: + Documentation, - Library (Lib) stage: patch review |
| 2016-11-22 12:43:31 | Wheerd | create | |