This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: [Patch] Stop using inet_ntoa() when possible.
Type: Stage:
Components: Extension Modules Versions: Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: EdSchouten
Priority: normal Keywords: patch

Created on 2016-11-05 11:37 by EdSchouten, last changed 2022-04-11 14:58 by admin.

Files
File name Uploaded Description Edit
patch-inet_ntoa.diff EdSchouten, 2016-11-05 11:37 Patch for socketmodule to use inet_ntop() when available review
Messages (1)
msg280109 - (view) Author: Ed Schouten (EdSchouten) * Date: 2016-11-05 11:37
Modern C code should use inet_ntop()/inet_pton() as opposed to inet_addr()/inet_aton()/inet_ntoa().

Though the former functions may typically act as drop-in replacements for the latter, the inet_addr()/inet_aton() functions still have the advantage over inet_pton() of allowing you to parse IPv4 addresses that don't use the dotted quad notation (e.g. '0x0a000001' for 10.0.0.1).

There is no difference between inet_ntop() and inet_ntoa(), as they both always print the address in dotted quad form. inet_ntop() does have the advantage of being thread-safe, as inet_ntoa() uses internal storage for the return value. In other words, we'd better not use inet_ntoa() at all.

Attached is a patch for Python's socketmodule that changes the existing call to inet_ntoa() to use inet_ntop() when available. This has the advantage of fixing the build on CloudABI (https://mail.python.org/pipermail/python-dev/2016-July/145708.html), which intentionally omits any APIs that are thread-unsafe.
History
Date User Action Args
2022-04-11 14:58:39adminsetgithub: 72805
2016-11-05 11:37:21EdSchoutencreate