classification
Title: Use the "U" format for parsing Unicode object arg in PyArg_Parse*
Type: enhancement Stage: resolved
Components: Interpreter Core Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: matrixise, python-dev, serhiy.storchaka, xiang.zhang
Priority: normal Keywords: patch

Created on 2016-10-22 20:53 by serhiy.storchaka, last changed 2016-10-23 15:34 by xiang.zhang. This issue is now closed.

Files
File name Uploaded Description Edit
parse_unicode_arg.patch serhiy.storchaka, 2016-10-22 20:53 review
Messages (4)
msg279219 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-10-22 20:53
Proposed patch uses the "U" format in PyArg_Parse* functions instead of the "O!" format with &PyUnicode_Type argument. This makes code cleaner, faster, and allows to remove additional PyUnicode_READY checks.

The patch is inspired by the patch of Xiang Zhang (issue28504).
msg279237 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-10-23 06:35
Thank you for your review Xiang. But seems your mail provider again is broken, and you will not receive the notification.
msg279253 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-10-23 12:12
New changeset d667913a81c6 by Serhiy Storchaka in branch 'default':
Issue #28511: Use the "U" format instead of "O!" in PyArg_Parse*.
https://hg.python.org/cpython/rev/d667913a81c6
msg279255 - (view) Author: St├ęphane Wirtel (matrixise) * (Python committer) Date: 2016-10-23 12:20
will you close the issue ?
History
Date User Action Args
2016-10-23 15:34:25xiang.zhangsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2016-10-23 12:20:14matrixisesetnosy: + matrixise
messages: + msg279255
2016-10-23 12:12:49python-devsetnosy: + python-dev
messages: + msg279253
2016-10-23 06:35:27serhiy.storchakasetmessages: + msg279237
2016-10-22 20:53:54serhiy.storchakacreate