classification
Title: Remove redundant definition of factorial on test_random
Type: Stage: resolved
Components: Tests Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: franciscouzo, python-dev, vstinner
Priority: normal Keywords: patch

Created on 2016-10-19 08:03 by franciscouzo, last changed 2016-10-19 08:13 by vstinner. This issue is now closed.

Files
File name Uploaded Description Edit
test_random.patch franciscouzo, 2016-10-19 08:03 review
Messages (2)
msg278965 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-10-19 08:11
New changeset c6588a7443a4 by Victor Stinner in branch 'default':
Close #28476: Reuse math.factorial() in test_random
https://hg.python.org/cpython/rev/c6588a7443a4
msg278966 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2016-10-19 08:13
Thanks for your contribution Francisco.

test_random still pass. I pushed your safe and well contained patch. It don't see any good reason why test_random had its own pure (and slow) Python implementation of factorial(), it's probably because test_random.py was written before math.factorial() was added (Python 2.6).
History
Date User Action Args
2016-10-19 08:13:25vstinnersetnosy: + vstinner
messages: + msg278966
2016-10-19 08:11:57python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg278965

resolution: fixed
stage: resolved
2016-10-19 08:03:45franciscouzocreate